Re: [PATCH v2] app/testpmd: fix issue with memory leaks when quit testpmd

[David Marchand <david.marchand@redhat.com>]

On Mon, Mar 14, 2022 at 6:59 AM Ke Zhang <ke1x.zhang@intel.com> wrote:
>
> when dpdk is compiled in ASan, there is a memory leaks after
> quit testpmd if set mcast_addr, this patch fix this issue.

The memory leak is present regardless of ASan being compiled in.
Plus, afaiu, the issue happens too when closing a port.

I'd rather rephrase like:
"""
A multicast address pool is allocated for a port when using mcast_addr
testpmd commands.

When closing a port or stopping testpmd, this pool was not freed,
resulting in a leak.
This issue has been caught using ASan.

Free this pool when closing the port.
"""

>
> Error info as following:
> ERROR: LeakSanitizer: detected memory leaksDirect leak of
>        192 byte(s)
> 0 0x7f6a2e0aeffe in __interceptor_realloc
>         (/lib/x86_64-linux-gnu/libasan.so.5+0x10dffe)
> 1 0x565361eb340f in mcast_addr_pool_extend
>         ../app/test-pmd/config.c:5162
> 2 0x565361eb3556 in mcast_addr_pool_append
>         ../app/test-pmd/config.c:5180
> 3 0x565361eb3aae in mcast_addr_add
>         ../app/test-pmd/config.c:5243
>

This patch needs a Fixes: tag.


> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> ---
>  app/test-pmd/testpmd.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index fe2ce19f99..f7e18aee25 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3136,6 +3136,12 @@ close_port(portid_t pid)
>                         continue;
>                 }
>
> +               if (port->mc_addr_nb != 0) {
> +                       /* free the pool of multicast addresses. */
> +                       free(port->mc_addr_pool);
> +                       port->mc_addr_pool = NULL;
> +               }
> +

Nit: I would introduce a helper in app/test-pmd/config.c, for example,
mcast_addr_pool_destroy.


>                 if (is_proc_primary()) {
>                         port_flow_flush(pi);
>                         port_flex_item_flush(pi);
> --
> 2.25.1
>


-- 
David Marchand