From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D41EDA00C2; Wed, 30 Nov 2022 16:02:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF6E940A79; Wed, 30 Nov 2022 16:02:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5A7C740151 for ; Wed, 30 Nov 2022 16:02:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669820568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ieOYJbf21km8l1yB/rChb3MAn8K+toqGwLxvvvpIGdA=; b=QzvRPT5cxyoxTzcEhUkO2ZMM+vUupxCd/8X4Jf/iqiKqVF6w/A6RefMqYhClbMn5U9d4HV U6uga8mLsv/C/G3f9nxjPY3xEXV1LIIwY8B160iWJlFH4+DQZdusowjVJPvk1Ieu6wmXC9 5q7l3AvW4GjXfLjKcgknISGIfBizf0E= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-190--6_-wvTAMFuOUp2ram9jcg-1; Wed, 30 Nov 2022 10:02:41 -0500 X-MC-Unique: -6_-wvTAMFuOUp2ram9jcg-1 Received: by mail-pj1-f71.google.com with SMTP id my9-20020a17090b4c8900b002130d29fd7cso2561903pjb.7 for ; Wed, 30 Nov 2022 07:02:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ieOYJbf21km8l1yB/rChb3MAn8K+toqGwLxvvvpIGdA=; b=JBnpZtqxj+DKCHM/WCbYEOiyjblaMaUiwvkEld0fNO3eczpc0njGFxWa8lb41yfLuh 2ktMA/lHzdNP+cuggnPgtomGiX3Zg1l2b9CWu3xAnwZdZcg4t6Srd5KDGr2wywme3lUe o/M9PySTHDl7/qp/opzbstGK7n3Jh0qJCQKcr9AqyUjf67O6g4lGoVyIxhMVelYu6QCI iDa9v4PTgUD1bZbfdtNwykZdFKrHZrE2hBOeseaeluDauhg5mdHfLkB9UgRKgQTsYbC0 ryBhLppDzj8e1IwTgqWbby+MLBHuTKWAwwAh0nGjvZtVpvi+v0fouRVX1PUTY12ZGdAZ K5Tw== X-Gm-Message-State: ANoB5plMouC44HD2Zn7quXgEZaD+C6dOGBclNPMdJai5ANy24dFVQzck KXOT9vxNaVKqLtiR9bluo38PmQp/615wWGLCyt6z+GfSm6SLqWECWymsCYgSgfbsxif4hPFC5TJ E467+Ks60YcX0qC/qH/s= X-Received: by 2002:a63:2163:0:b0:474:d6fa:f574 with SMTP id s35-20020a632163000000b00474d6faf574mr40392923pgm.190.1669820558879; Wed, 30 Nov 2022 07:02:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf6ufqh5pZ7+jmIwxeWbeJ/cc5nr7w5zgJEAbDv5uG6Hp3VJtH4+VrJRu0BqCLK8mfZsPfGndPKYnPCKfFgbeFQ= X-Received: by 2002:a63:2163:0:b0:474:d6fa:f574 with SMTP id s35-20020a632163000000b00474d6faf574mr40392896pgm.190.1669820558498; Wed, 30 Nov 2022 07:02:38 -0800 (PST) MIME-Version: 1.0 References: <20221129140032.35940-1-david.marchand@redhat.com> <20221130100204.214181-1-david.marchand@redhat.com> <191d5966-dd66-3a26-2789-6c6e5ce78aa2@amd.com> In-Reply-To: <191d5966-dd66-3a26-2789-6c6e5ce78aa2@amd.com> From: David Marchand Date: Wed, 30 Nov 2022 16:02:26 +0100 Message-ID: Subject: Re: [PATCH v2] drivers: fix symbol exports when map is omitted To: Ferruh Yigit , Luca Boccassi , Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 30, 2022 at 11:44 AM Ferruh Yigit wrote: > > On 11/30/2022 10:02 AM, David Marchand wrote: > > ld exports any global symbol by default if no version script is passed. > > As a consequence, the incriminated change let any public symbol leak > > out of the driver shared libraries. > > > > Hide again those symbols by providing a default map file which > > unexports any global symbol using a local: * catch-all statement. > > > > The checks are skipped for this default map file as it is intentionnally > > an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol > > maps")) and there is nothing else to check in this map. > > > > While at it, move Windows specific objects where needed for better > > readability. > > > > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") > > Cc: stable@dpdk.org > > > > Reported-by: Luca Boccassi > > Signed-off-by: David Marchand > > Tested-by: Ferruh Yigit > > Tested v2, looks good. > 'check-symbol-maps.sh' warning fixed too. Thanks Ferruh. Bruce / Luca, could you review / confirm it is ok for you? -- David Marchand