From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Cc: stable@dpdk.org, Sachin Saxena <sachin.saxena@nxp.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH 1/2] raw/skeleton: fix selftest
Date: Tue, 14 Mar 2023 09:39:11 +0100 [thread overview]
Message-ID: <CAJFAV8xZfFz5v=xOZnPMQd0pV+2Svoby8TqPkho8C6CMVc8V5w@mail.gmail.com> (raw)
In-Reply-To: <20230310142604.2409586-1-david.marchand@redhat.com>
On Fri, Mar 10, 2023 at 3:26 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> ASan reported issues in this driver.
>
> rte_rawdev_obj_t context object points at a uint16_t.
> skeleton_rawdev_enqueue_bufs() and skeleton_rawdev_dequeue_bufs() were
> incorrectly casting to an int.
>
> The enqueue/dequeue selftest had a leak on the enqueued string and was
> wrong in passing a rte_rawdev_buf pointer array.
> Fix this by allocating buffers on the stack and check that returned
> string is the expected one.
>
> Bugzilla ID: 1175
Thomas, just a note if you are the one to apply this one.
I was looking at bugzilla, and this issue was actually reported a
while back, as bz 999, so the commitlog needs some update before
applying.
> Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver")
> Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2023-03-14 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 14:26 David Marchand
2023-03-10 14:26 ` [PATCH 2/2] test: add rawdev to fast tests David Marchand
2023-03-16 8:27 ` Hemant Agrawal
2023-03-13 2:17 ` [PATCH 1/2] raw/skeleton: fix selftest Jiang, YuX
2023-03-14 8:39 ` David Marchand [this message]
2023-03-16 8:26 ` Hemant Agrawal
2023-03-16 12:51 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xZfFz5v=xOZnPMQd0pV+2Svoby8TqPkho8C6CMVc8V5w@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=shreyansh.jain@nxp.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).