From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C769142278; Fri, 1 Sep 2023 16:31:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3C5140285; Fri, 1 Sep 2023 16:31:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CDE254014F for ; Fri, 1 Sep 2023 16:31:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693578671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZzFgUIhluQP3bIij8RjAopyQ8csoKrfskvOpisxyubI=; b=CqhUnYcN9crYRl6uXqwUpEiN5hBCsitfHX1smrb4JV3ObEkCLEPozNR9hiOcLkieZ9cwZT Nq7Boj1o7Oi8TYj9eUVlPdoKZgMS4POA/GBjKCTEydCJ5D+WZ2XkwK6NeeHfrTvMHrfxRO 2hbn+a5PhSvAL8UjU6Ql7pvQIlvBaZg= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-6lBfZaH1PDOhv36PbpS05Q-1; Fri, 01 Sep 2023 10:31:09 -0400 X-MC-Unique: 6lBfZaH1PDOhv36PbpS05Q-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5007f3d3293so2587800e87.3 for ; Fri, 01 Sep 2023 07:31:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693578668; x=1694183468; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZzFgUIhluQP3bIij8RjAopyQ8csoKrfskvOpisxyubI=; b=G8TQb6KFlB2g8eYyAw7eamA6gt0prbMc1jomRHbuGtt/9pXODW/YD2blCZCcG8cOIN zcaCydbvwrMjYVcrWtD99tLiyI4070kq+gbtQgv/za9li1uE5iqOd8YG0PJSgMpoudlG ANOLo80lZNzYUEThqu1tW3+eq25WnLV9h7mWlxwewAHQmWyM0rTwD8YVb4S+8+kOokkc ICPHMCaLiNhOWUc43arfMP0rHv0hOhPS2Ofgkh+I3g0fYxLrl91FPpMscKXOgq8y7uhg 5pT3UnyEdpsqyg4P7qqlm7bT2T9ZxASb51fScLRuWftm78ysSsolsIqCZlBOEvIohIPz lrQg== X-Gm-Message-State: AOJu0Yy/Utkx0APEPmrAFV9jqUy18BmriZb7HyPptKZOJGRJ4nL2AWpJ 8aiUkIM2TRneeR0Zwl+4b9NzJWnTM6t4PsFO/N+gXF+MMjbIc9leZ5XEcWRSgHxaHTotw4zP1Nm R+5IMLxAogedaOQUkLVw= X-Received: by 2002:ac2:5e2f:0:b0:500:7696:200 with SMTP id o15-20020ac25e2f000000b0050076960200mr1598237lfg.59.1693578667951; Fri, 01 Sep 2023 07:31:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbWEIXiNkAJAN8yGjxC8K42GAhdCDYYy3s1V0a+pUCH50cwKHaz5J2ydC8byy12Xob4IxXSR+uilITUBK7DmY= X-Received: by 2002:ac2:5e2f:0:b0:500:7696:200 with SMTP id o15-20020ac25e2f000000b0050076960200mr1598219lfg.59.1693578667597; Fri, 01 Sep 2023 07:31:07 -0700 (PDT) MIME-Version: 1.0 References: <20230901142332.588856-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Fri, 1 Sep 2023 16:30:56 +0200 Message-ID: Subject: Re: [PATCH 1/2] build: fail if explicitly requested lib is unbuildable To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 1, 2023 at 4:29=E2=80=AFPM David Marchand wrote: > > On Fri, Sep 1, 2023 at 4:23=E2=80=AFPM Bruce Richardson > wrote: > > > > When the user passes a list of desired libraries to build via the > > "enable_libs" option, the expectation is that those libraries should be > > part of the build. However, if those libs have either external or > > internal dependencies, they still may be silently disabled, for example= : > > running "meson setup -Denable_libs=3Dsecurity build" will successfully > > run, but the security lib will not be configured as "cryptodev" is > > missing. > > > > We can fix this by setting a flag to indicate when the libraries are > > specified via an enable_libs flag. If so, then we error out when a > > library is unbuildable, giving a suitable error message. For the above > > example case, the "meson setup" run fails with: > > > > Message: Disabling security [lib/security]: missing internal dependency= "cryptodev" > > > > lib/meson.build:218:16: ERROR: Problem encountered: Cannot build explic= itly requested lib "security". > > Please add missing dependency "cryptodev" to "enable_libs" opti= on > > > > Signed-off-by: Bruce Richardson > > I remember setting a enable_drivers=3Dnet/af_xdp on a system lacking > libbpf-devel and not getting warned about its absence. > So I suspect enable_drivers is affected by the same issue. Arf sorry, did not see it was a two patch series :-). --=20 David Marchand