From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF11AA04B5; Mon, 16 Nov 2020 14:50:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A96A5323E; Mon, 16 Nov 2020 14:50:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 4A981F3E for ; Mon, 16 Nov 2020 14:50:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605534600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QlYh3iwV5WQEYdemqN4LzdXiFjlidWR0fG0WZnTmrwU=; b=OcxoJYk5Jmt1X7ePah3MaEIpLeqSJHg3XbJrCXlxA89md0XMbqfNrXaajHJmu5SRbx7q0C 1hFxUMl4P/qPBoX3FhltV3CyGGR8GciEZ39F7AtVZ5ahQm7GsxPbxwQXVU2eEPlBtnnfxm 7BMyU0RwGPhjiTbKApWf6PFQb4MjFQQ= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-493-wIi0rwjXMHSVWJFGiCVHxg-1; Mon, 16 Nov 2020 08:49:57 -0500 X-MC-Unique: wIi0rwjXMHSVWJFGiCVHxg-1 Received: by mail-vk1-f198.google.com with SMTP id q62so5564123vka.22 for ; Mon, 16 Nov 2020 05:49:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QlYh3iwV5WQEYdemqN4LzdXiFjlidWR0fG0WZnTmrwU=; b=CZrNiGbU+eY/sHyXFlGS6XUtnSLK6UX85gDMztcd1x3dRpAUrimnAMNBcJLXD+zNAP 5NxZnhBJwp8ugwrikohw/IOKCzmzJHvqN7o+7N0vnGrYyPO19fhy6kDeocOo0/9w0EOC qxU6bR0vjyl3DXBrqi7bTr0QD8u6Ya/5KKkYnwyycWnDHJd0Yui3koyxmwEAUbeWbRpY UO+OhHtCOPYP4ogajiM9rqmtYIPl6CGHuIyvCsuizbmSRMEO3zLw2e5j1XvUvp8VzMtL NTJsdPUIYcf742llE4zlvez5hYd2VTDLiWpItd0LB96OIvn9clhVsACfg23LNoPTinCG 4rtQ== X-Gm-Message-State: AOAM531Olksoptv2LcuF0d0G75M8ZYXK8btlwPNppI0z7qYjSk29/93C V8vVRNZTqjyljALuZdwpBWiBqVMNvXLvl6r0RqsPac1fYFsWmLsQb2F2L5dGm9hno/Q3vCvo+qS 9Eyg0F9Rk6AQdQFkrVMQ= X-Received: by 2002:a67:f8c5:: with SMTP id c5mr8210912vsp.18.1605534597330; Mon, 16 Nov 2020 05:49:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQPObd9VhOvHaPQP8d0zRsJI35GP+LZs0M0Heexfpwy5pKDR01wBdPQQlra6FSkmTSFe0VXgG+4c1ccCRlrQQ= X-Received: by 2002:a67:f8c5:: with SMTP id c5mr8210883vsp.18.1605534597056; Mon, 16 Nov 2020 05:49:57 -0800 (PST) MIME-Version: 1.0 References: <20201106170833.234029-1-thomas@monjalon.net> In-Reply-To: <20201106170833.234029-1-thomas@monjalon.net> From: David Marchand Date: Mon, 16 Nov 2020 14:49:45 +0100 Message-ID: To: Thomas Monjalon , Bruce Richardson Cc: dev , Hemant Agrawal , Sachin Saxena , Stephen Hemminger , Long Li , Gagandeep Singh , Somalapuram Amaranath , Akhil Goyal , Anoob Joseph , Timothy McDaniel , Nipun Gupta , "John W. Linville" , Steven Webster , Matt Peters , "Wei Hu (Xavier)" , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Heinrich Kuhn , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Matan Azrad , Ferruh Yigit , David Hunt , Maxime Coquelin , Chenbo Xia Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/1] build: align wording of non-support reasons X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 6, 2020 at 6:09 PM Thomas Monjalon wrote: > > Reasons for building not supported generally start with lowercase > because printed as the second part of a line. > > Other changes: > - "linux" should be "Linux" with a capital letter. > - ARCH_X86_64 may be simply x86_64. > - aarch64 is preferred over arm64. > > Signed-off-by: Thomas Monjalon After patch, we end up with: 1 'missing dependency, DPDK KNI library' 1 'missing dependency, DPDK VMBus driver' 1 'missing dependency, "libAArch64crypto"' 1 'missing dependency, "libbpf"' 1 'missing dependency, "libisal"' 1 'missing dependency, "libnfb"' 1 'missing dependency, "libpcap"' 1 'missing dependency, "librt"' 1 'missing dependency, "libsze2"' 1 'only supported on Linux and Windows' 1 'only supported on x86' 2 '' 2 'missing dependency, DPDK DPAA2 mempool driver' 2 'missing dependency, DPDK vhost library' 2 'missing dependency, "libcrypto"' 2 'missing dependency, "libfdt"' 2 'missing dependency, "' + libname + '"' 2 'missing dependency, "zlib"' 2 'only supported on x86_64 Linux' 3 'only supported on x86_64 and aarch64' 4 'missing dependency, "libmusdk"' 4 'only supported on 64-bit' 4 'only supported on 64-bit Linux' 5 'IPSec_MB version >= @0@ is required, found version @1@' 5 'missing dependency, "libIPSec_MB"' 6 'not supported on Windows' 32 'only supported on Linux' I wonder if we could use some helper here, like for OS checks and avoid getting those strings "not supported on XXX" "only supported on XXX" in libs/drivers meson.build. But otherwise, I tried it, looked at meson logs, LGTM. Acked-by: David Marchand -- David Marchand