From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A9B4A0C43; Tue, 19 Oct 2021 09:02:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8215340683; Tue, 19 Oct 2021 09:02:31 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6485B4003E for ; Tue, 19 Oct 2021 09:02:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634626949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lS7HLuVISPfo/RjYbuyNwcmq4JOjiiaeUvNVeHHRXk0=; b=ZqPKHvrsq2GaAE1AeZPbIyi+VE8WXyoiFzzYZWvAacJkFu/oPX4IOcW6yqHOour/FERsqS 983x6C1P4Nz1LUhqJxoHpfRUOWD3p/+G+xBBkvntsVdOk1WiQU9IVCyQVq99pqZ4cN4VZo vLToyXevjrXtvpmiQXEahiYCXr0U/sA= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-DsUHT0iePoaaMTezyftqnQ-1; Tue, 19 Oct 2021 03:02:28 -0400 X-MC-Unique: DsUHT0iePoaaMTezyftqnQ-1 Received: by mail-lj1-f200.google.com with SMTP id f6-20020a2e9e86000000b00211349f9ce3so345699ljk.3 for ; Tue, 19 Oct 2021 00:02:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lS7HLuVISPfo/RjYbuyNwcmq4JOjiiaeUvNVeHHRXk0=; b=u9Q+0YDfiT+PM7PhOlvAtQqUTSsAavvDjjFy7PgEpHrJ/jeeFv5sRxiJUlhJKQNjmo UHIe4p4Yjw7S2HpUfGLUV+qzP/CU18qvxJEFsfAtcdxjGfBTvJIdT4VGceyGbXXyIbD7 MfcditPhtMuUOE4t6xb7gx9Nc7Lq+aPt2jcBtxAJCsRXxKiTJtUYoAPY0ezhnS5gOTMM c8PSSdyTjhoeUd0125WtTOGBA4cTmIRYIRaJ9wDckXjweS1pP/15aMwiNB6yhGIStEwP kYNkxDqtiMvu/N4FrjlucTI4VCZqtXAjz3u29f3Nad6EhJ5Wo7K7DWKPcndQAz2FUho+ 48rA== X-Gm-Message-State: AOAM533C+ykFVZL6yTTlaBUuichrc3dCf35wcSfMpqkwXlmHAxlR6GZO tg+9xYoBnZA+YiV/UOUrPNDF48x7AOl3blVqkJKbkOIqc4DCAD6wfvO0pApLEIwM6WOTOf18jGF j6R0XI1Z4DavrrRS2nG8= X-Received: by 2002:a2e:b528:: with SMTP id z8mr4859808ljm.55.1634626947004; Tue, 19 Oct 2021 00:02:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNOYOLcAjJ2pQGerSZL6Bph3TPs9oSK4MIk9Mse0xSEVrfrUapkWy0Ry+T1PnbVm2WVprQ5ia3xabsycKhZDc= X-Received: by 2002:a2e:b528:: with SMTP id z8mr4859801ljm.55.1634626946845; Tue, 19 Oct 2021 00:02:26 -0700 (PDT) MIME-Version: 1.0 References: <1634153265-193315-1-git-send-email-vladimir.medvedkin@intel.com> <1634233699-197151-1-git-send-email-vladimir.medvedkin@intel.com> <543fb591-d38a-5573-1bbc-db6a0c624893@intel.com> In-Reply-To: <543fb591-d38a-5573-1bbc-db6a0c624893@intel.com> From: David Marchand Date: Tue, 19 Oct 2021 09:02:15 +0200 Message-ID: To: "Medvedkin, Vladimir" Cc: dev , "Wang, Yipeng1" , "Gobriel, Sameh" , Bruce Richardson , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 15, 2021 at 3:02 PM Medvedkin, Vladimir wrote: > > I am confused. > > Does it mean that rte_jhash_32b is not compliant with rte_hash_create API? > > > > I think so too, because despite the fact that the ABI is the same, the > API remains different with respect to the length argument. Sorry I don't follow you with "ABI is the same". Can you explain please? I am not against the fix, but it seems to test something different than what an application using the hash library would do. Or if an application directly calls this hash function, maybe the unit test should not test it via rte_hash_create (which seems to defeat the abstraction). -- David Marchand