From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 064AFA2F18 for ; Thu, 3 Oct 2019 12:08:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9C631C026; Thu, 3 Oct 2019 12:08:48 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 8A6831BFD8 for ; Thu, 3 Oct 2019 12:08:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570097325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ah0XUOtkAi0Fzf7TzJDlX2mdBt5nyzN7j2xnBK8vcsY=; b=CT9AvWi8bAMOLSz+QXi+e6xnI1bnZ/mIxS7+9mqFRcwxHIUTWJ1B5usMvPA253LcCP4sqo JqmC9nW54MMLGIyWW2WNa69KgFFKUf9eZOo3QqHvYgj4TyyBfN+3xQy2QM0xbPgqVRwBPs IILV61dHlF1yDWFektPu0dLSH/cgoDU= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-1DLl3i9xOyaL3y6SaSiGHg-1; Thu, 03 Oct 2019 06:08:42 -0400 Received: by mail-vk1-f197.google.com with SMTP id w1so846687vkd.10 for ; Thu, 03 Oct 2019 03:08:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F4InjS8DQbydcy5vBBUoYijKz/jziLAu24tQvPGdVV8=; b=IkP/pKd58u392Cw7UhdGAE3gElPUg4SDkyZv9jq5xDRZLZ/q2wGuLdbqR8jhno+afl kuikSqHay3Kk6V6fAdhg0yIJTq50/kFNbd2Erk6cgGh1tDGGqL8D5wVulLseNl9O0WQY B+6rC/AR/bWoOKH+ddq60LxfLXLdtWuwPJSiGuLKcuy8HrkMtF4Fb7FqpV6kfctzv3Ql R0PWsSqMl1em21uCUCpiroxH1zBMME7TKd8wwBqRKuTDf5UwViGgRsiIJMbyJFSDGsGt jA+g3kMgc3K1hJ7QAkEh/Dyadpae9NV+YDW0ZO5XKkTHQgrBnd/ZoREmKa3lI5pRSax8 zjtg== X-Gm-Message-State: APjAAAXlEVWz0L2YJPRRgMVU8VFKKjgwqZPZba2qExzaNTZrkkS3eoBd HgwxrdMoXbR7/SYzAw8XRG9ARdcqc+I3v5vsY7dh/jmGm2mejBJewv2iYqc1gbtAzUg7942ms1m 4UJ/wjnHkvtdfSHv1kng= X-Received: by 2002:a67:af08:: with SMTP id v8mr4493958vsl.198.1570097321923; Thu, 03 Oct 2019 03:08:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/FhRZaOabMgsXOpmmt1IgiG/B0g+rDFxuwe9Vl/8/B2vcxB06DnNx7ApMCblwx+fSpNUNXLZKo60LLU9et8A= X-Received: by 2002:a67:af08:: with SMTP id v8mr4493946vsl.198.1570097321591; Thu, 03 Oct 2019 03:08:41 -0700 (PDT) MIME-Version: 1.0 References: <1570035347-18360-1-git-send-email-david.marchand@redhat.com> <20191003092117.GA1803@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20191003092117.GA1803@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 3 Oct 2019 12:08:30 +0200 Message-ID: To: Bruce Richardson Cc: dev , Thomas Monjalon X-MC-Unique: 1DLl3i9xOyaL3y6SaSiGHg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] devtools: reset compilation flags for each target X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 3, 2019 at 11:21 AM Bruce Richardson wrote: > > On Wed, Oct 02, 2019 at 06:55:47PM +0200, David Marchand wrote: > > Same idea than overriding PATH and PKG_CONFIG_PATH, it can be quite > > useful to override compilation flags like CFLAGS, CPPFLAGS and LDFLAGS > > for cross compilation or libraries that won't provide a pkg-config file= . > > > > Fixes: 272236741258 ("devtools: load target-specific compilation enviro= nment") > > > > Signed-off-by: David Marchand > > --- > > No strong objection to this change, but for meson the better way to handl= e > this may be to put these flags into the cross-file used for the build. By > explicitly passing CFLAGS etc. to the build, I'm not sure what the > behaviour is with regards to passing those flags to cross-built vs > native-built components. For a cross-compile, not all CFLAGS should be > passed to the build of pmdinfogen, for instance. Ok, I see. Then the only usecase would be for locally built libraries that meson can't find by itself. A bit hackish too. Mm, is there a way to tell meson "library X (CFLAGS, LDFLAGS) is (xx, yy)" = ? I could write some local .pc files and override PKG_CONFIG_PATH... Any better idea ? --=20 David Marchand