From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 560F341EB1; Thu, 16 Mar 2023 16:52:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA09742D62; Thu, 16 Mar 2023 16:52:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AAA7240DF6 for ; Thu, 16 Mar 2023 16:52:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678981949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q8uke88wcMb3BMx2ShiPM8wlwzM4/a5O1Ph2f/iAcYo=; b=ZuvEUvtpx5s6diPY1mk0af57+z+VLOHfaRz6V78QwHnVwHD+Z8PEEJBpkYD3uxMFNKx10w EKxLqbsFiqKremO/gTNuo4oBOWsTUlPSChGWIbgLkVwA2pLjzE55kS6NwZ4bbMn2L4Q7As 3p0jEViSGvwsk9miW5A0t7hliYFZjFE= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-B5iBOJE5NdezEnZEWIG7MQ-1; Thu, 16 Mar 2023 11:52:29 -0400 X-MC-Unique: B5iBOJE5NdezEnZEWIG7MQ-1 Received: by mail-pf1-f200.google.com with SMTP id h66-20020a628345000000b00625e0121e40so1326101pfe.1 for ; Thu, 16 Mar 2023 08:52:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678981947; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q8uke88wcMb3BMx2ShiPM8wlwzM4/a5O1Ph2f/iAcYo=; b=ILNzb4P/RsptzReQYfUIaU4XC2M70t9j+vFbNLcrCZpFtzo4JSoTi44iHbG0l7vyfu wTVfnASPhkdAEFPFHnMMFzpOjvhPEyPL4mwW5o7hs3veL1uHkMWpHZX9PzTSsIGTnD7I zG583ofOBMZphQs3ULiSq2S/pp0OC9qtPeHpiw8R1vzDpuReQL+IpwlixeQdEWuzTYQq Xx4e/2gPVcvhUoQsVAmkilqju7hu1jcja6MGW0bhEgXrUvMY0T9KgJvURH8iQvvbH4ZU HQ45JuDTdEcgxaAQq7/5scd8jkYobxK0Knl6J+IirOeZJCkdxexjPA4WRKcFjBZRhCwZ Jymw== X-Gm-Message-State: AO0yUKUbkJ1pNnbz2UhOed3mNKozI2QQng3UwIpQN5HM9/lm2BpWyqnQ 5SEBTRv7ziYSTLeBgM6PKgInDLvyknTgkFvT6JO70DhgHdu0oWiVeLZQxwa6u+TkoPc+luVnN2p wg0XxOUEyqKPzOXJv7lVVvfmRqrCHxg== X-Received: by 2002:a05:6a00:1506:b0:625:ce0d:e69b with SMTP id q6-20020a056a00150600b00625ce0de69bmr1782217pfu.5.1678981947746; Thu, 16 Mar 2023 08:52:27 -0700 (PDT) X-Google-Smtp-Source: AK7set//vHdsNlqDGBD/1J8yn3lcCQQkcDKSRi92+F0C9fDxgoWgug9panEMsjM+EmfeMrmMEo+sWWMEMwU8+PDIH/o= X-Received: by 2002:a05:6a00:1506:b0:625:ce0d:e69b with SMTP id q6-20020a056a00150600b00625ce0de69bmr1782193pfu.5.1678981947287; Thu, 16 Mar 2023 08:52:27 -0700 (PDT) MIME-Version: 1.0 References: <20221220123754.239802-1-ktraynor@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 16 Mar 2023 16:52:16 +0100 Message-ID: Subject: Re: [PATCH 21.11] ring: squash gcc 12.2.1 warnings To: dev , Honnappa Nagarahalli , Konstantin Ananyev , Thomas Monjalon Cc: stable@dpdk.org, alialnu@nvidia.com, Bruce Richardson , Luca Boccassi , "Xueming(Steven) Li" , Patrick Robb , Kevin Traynor X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 16, 2023 at 12:00=E2=80=AFPM David Marchand wrote: > > On Tue, Dec 20, 2022 at 1:38=E2=80=AFPM Kevin Traynor wrote: > > > > gcc 12.2.1 on Fedora 37 is giving stringop-overread and > > stringop-overflow warnings when compiled with --buildtype=3Ddebug > > e.g. [1]. > > > > These are not yet fixed on main branch. They look similar > > to the overflow issues previously squashed in rte_memcpy with > > commit b5b3ea803e47 ("eal/x86: ignore gcc 10 stringop-overflow warnings= ") > > > > In order to ensure DPDK 21.11.3 compiles on Fedora 37, squash these > > warnings. If a subsequent cleaner fix becomes available on from main > > branch it can be backported to later DPDK 21.11 LTS release. > > > > [1] > > lib/ring/rte_ring_elem_pvt.h:100:25: error: > > =E2=80=98memcpy=E2=80=99 reading 32 bytes from a region of size 4 > > [-Werror=3Dstringop-overread] > > 100 | memcpy((void *)(ring + idx), > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 101 | (const void *)(obj + i), 32); > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > lib/ring/rte_ring_elem_pvt.h:234:25: error: > > =E2=80=98memcpy=E2=80=99 writing 32 bytes into a region of size 4 overf= lows the destination > > [-Werror=3Dstringop-overflow=3D] > > 234 | memcpy((void *)(obj + i), (void *)(ring + idx), 32)= ; > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > Signed-off-by: Kevin Traynor I see Konstantin is ok with it and I think Honnappa is off for some days. So I adjusted the commitlog for the main branch, and applied. For the record, there is a bugzilla opened for this issue: https://bugs.dpdk.org/show_bug.cgi?id=3D1062 --=20 David Marchand