From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption
Date: Thu, 21 Nov 2019 17:17:37 +0100 [thread overview]
Message-ID: <CAJFAV8x_djX+-zuNcEg9+J6eT3OdN+fEsqpReut9he2yGMVNmg@mail.gmail.com> (raw)
In-Reply-To: <8055a2ec-42ef-30c2-5452-b0e8b92caa87@intel.com>
On Thu, Nov 21, 2019 at 4:36 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
> > index 90694a3309..217d577018 100644
> > --- a/app/test-pmd/testpmd.h
> > +++ b/app/test-pmd/testpmd.h
> > @@ -58,8 +58,6 @@ typedef uint16_t portid_t;
> > typedef uint16_t queueid_t;
> > typedef uint16_t streamid_t;
> >
> > -#define MAX_QUEUE_ID ((1 << (sizeof(queueid_t) * 8)) - 1)
>
> No strong opinion, but would it be simpler if assign 'MAX_QUEUE_ID' to
> 'RTE_MAX_QUEUES_PER_PORT' instead?
> #define MAX_QUEUE_ID RTE_MAX_QUEUES_PER_PORT
This was my first solution once I spotted this.
But I prefer to globally replace: when reading this code, using
MAX_QUEUE_ID leaves the impression that testpmd has its own
restriction on max queue count.
--
David Marchand
next prev parent reply other threads:[~2019-11-21 16:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 15:12 David Marchand
2019-11-21 15:36 ` Ferruh Yigit
2019-11-21 16:17 ` David Marchand [this message]
2019-11-21 16:23 ` David Marchand
2019-11-21 21:22 ` Thomas Monjalon
2019-11-21 16:45 ` Stephen Hemminger
2019-11-21 20:32 ` David Marchand
2019-11-21 21:25 ` Thomas Monjalon
2019-11-21 21:55 ` Thomas Monjalon
2019-11-22 10:43 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-11-22 12:24 ` Ferruh Yigit
2019-11-22 13:12 ` Thomas Monjalon
2019-11-22 13:14 ` Ferruh Yigit
2019-11-22 13:48 ` [dpdk-dev] [PATCH] devtools: disable automatic probing in null testing Thomas Monjalon
2019-11-22 13:56 ` Ferruh Yigit
2019-11-22 15:56 ` David Marchand
2019-11-24 22:52 ` Thomas Monjalon
2019-11-22 14:03 ` Gaëtan Rivet
2019-11-22 14:36 ` Thomas Monjalon
2019-11-22 14:14 ` [dpdk-dev] [PATCH v2] app/testpmd: reduce memory consumption Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8x_djX+-zuNcEg9+J6eT3OdN+fEsqpReut9he2yGMVNmg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).