From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F606A04C1; Thu, 21 Nov 2019 17:17:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 029382BA3; Thu, 21 Nov 2019 17:17:54 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 05F1B2BA2 for ; Thu, 21 Nov 2019 17:17:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574353071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f/WyRp9dXcKyr/1auYmPt4rnyHa2Mj4/yrCW4eHtqfA=; b=CWlmXXmrGfazCX06FDsJO0UzkUArMSIdD9RyZblPqs4SMAECBUMZ1WcBWo1Tqp5Sg/IMj8 Ww14gWMic2Ht31Er1WORry2J69btd6v0nKWHjO5KTiZ5vqR+fTZOf46trBPe00j2a+fNk5 OV1uRAMDOblv25bh2Q4gDEKK4xMSJiw= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-dejlf2OgOHaEllXPOSETtA-1; Thu, 21 Nov 2019 11:17:49 -0500 Received: by mail-vs1-f70.google.com with SMTP id n7so689048vsp.4 for ; Thu, 21 Nov 2019 08:17:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+zY4N6xwGxRB59S5od6vcKPazK+fbzD9/uZvAWj/s5U=; b=p6F345GrFWPaH2109DgyU16riSf1TEcHrX2YCmXTjdfJnl6F0Sbjiel+WcrF6OU78C RmQu+wXcDpG+sGbnK5zU9rtsaYQlsZvj16GOZqQEJM1a5Drhi8t1lo0zekTqRYC5PIFV MMKM108PY/4lIK4/TSEKMKJz2ZszMTJn48SxuyBKhOqa018SIl8AODu9FhLyC4EVZTPF DE7V3XCzXGiAs/xIkHu+0RrUu/pwcwTwrhGdGbGGIJqGhektV+0jZg3LNQCuUw2zmAHK n382ZUSJ2QgNKI5ElALByfXuw/EaiQB0qyWllr8Z7CfILinpifRmhie0N+qrBkuTRkpF Jd2Q== X-Gm-Message-State: APjAAAWqtwP2VFDRJfL+++UyFBb7HAVAUCuGc2v+alA5+w/e5TW5dXUQ NxuqsMG75ZGjXgWKVKcSwxWMsNpDcYTvmSqolmmGRjKVevSe3tMd0hxCj0nHcfdsLI+1UpRhrV1 IqufYJeCvWL1HktpeTw0= X-Received: by 2002:ac5:cddc:: with SMTP id u28mr5812148vkn.12.1574353069208; Thu, 21 Nov 2019 08:17:49 -0800 (PST) X-Google-Smtp-Source: APXvYqyCJXIDz6LyeWNqDtm0gJ3lzaM1kq77F0aVQosioDcp9lE3plk+CNDIQaKvUJicEG5MfrybHNxrO+1AaSY0EdE= X-Received: by 2002:ac5:cddc:: with SMTP id u28mr5812118vkn.12.1574353068691; Thu, 21 Nov 2019 08:17:48 -0800 (PST) MIME-Version: 1.0 References: <20191121151256.20613-1-david.marchand@redhat.com> <8055a2ec-42ef-30c2-5452-b0e8b92caa87@intel.com> In-Reply-To: <8055a2ec-42ef-30c2-5452-b0e8b92caa87@intel.com> From: David Marchand Date: Thu, 21 Nov 2019 17:17:37 +0100 Message-ID: To: Ferruh Yigit Cc: dev , Thomas Monjalon , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger X-MC-Unique: dejlf2OgOHaEllXPOSETtA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 21, 2019 at 4:36 PM Ferruh Yigit wrote= : > > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > > index 90694a3309..217d577018 100644 > > --- a/app/test-pmd/testpmd.h > > +++ b/app/test-pmd/testpmd.h > > @@ -58,8 +58,6 @@ typedef uint16_t portid_t; > > typedef uint16_t queueid_t; > > typedef uint16_t streamid_t; > > > > -#define MAX_QUEUE_ID ((1 << (sizeof(queueid_t) * 8)) - 1) > > No strong opinion, but would it be simpler if assign 'MAX_QUEUE_ID' to > 'RTE_MAX_QUEUES_PER_PORT' instead? > #define MAX_QUEUE_ID RTE_MAX_QUEUES_PER_PORT This was my first solution once I spotted this. But I prefer to globally replace: when reading this code, using MAX_QUEUE_ID leaves the impression that testpmd has its own restriction on max queue count. --=20 David Marchand