From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, chenbox@nvidia.com
Subject: Re: [PATCH v2 3/4] vhost: rework async dequeue path error handling
Date: Wed, 15 Jan 2025 17:49:28 +0100 [thread overview]
Message-ID: <CAJFAV8x_qkgCeumMgqfFHA9B2YPaEtGcDBamL=J7nim__9b31g@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zSynZce6+yXsGK3Gd8rTqutgUK-G_Fq41CdwZGBL=Wdg@mail.gmail.com>
On Wed, Jan 15, 2025 at 5:42 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Jan 15, 2025 at 1:59 PM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
> >
> > This patch refactors the error handling in the Vhost async
> > dequeue path to ease its maintenance and readability.
> >
> > Suggested-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Btw, I would squash patch 2 and 3 (especially as you updated both sync
and async code at the same time in patch 4).
--
David Marchand
next prev parent reply other threads:[~2025-01-15 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 12:59 [PATCH v2 0/4] vhost: fix and improve dequeue error path Maxime Coquelin
2025-01-15 12:59 ` [PATCH v2 1/4] vhost: fix missing packets count reset when not ready Maxime Coquelin
2025-01-15 16:41 ` David Marchand
2025-01-15 12:59 ` [PATCH v2 2/4] vhost: rework dequeue path error handling Maxime Coquelin
2025-01-15 16:42 ` David Marchand
2025-01-15 12:59 ` [PATCH v2 3/4] vhost: rework async " Maxime Coquelin
2025-01-15 16:42 ` David Marchand
2025-01-15 16:49 ` David Marchand [this message]
2025-01-15 12:59 ` [PATCH v2 4/4] vhost: improve RARP handling in dequeue paths Maxime Coquelin
2025-01-15 16:46 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8x_qkgCeumMgqfFHA9B2YPaEtGcDBamL=J7nim__9b31g@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).