From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6F9E46093; Wed, 15 Jan 2025 17:49:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C76B4402B5; Wed, 15 Jan 2025 17:49:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0C02C40298 for ; Wed, 15 Jan 2025 17:49:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736959782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ektsrR1MXZ5eY0Ve/I0TkqM8FM2rd2jzpuGGf7fWWBE=; b=deKZeW+fH1mtu2BNy1wb7BlNSulJ6q3TiyX/FO20RjWoZqaJTqZfvZCA2ScY6rZ8cGW8lS yuf6d98q9WHLkYwJ4ElLxfD0IcXTac+e4u/uW616XrLO75JD+XDengkKQrwWjrxSqMUubZ CPtIqWQITSoQXRM9t1OOxrNIpR37uO0= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-E0Vw4QLkPUK-pKFUv9rcCg-1; Wed, 15 Jan 2025 11:49:41 -0500 X-MC-Unique: E0Vw4QLkPUK-pKFUv9rcCg-1 X-Mimecast-MFC-AGG-ID: E0Vw4QLkPUK-pKFUv9rcCg Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-30227bb16abso39419641fa.2 for ; Wed, 15 Jan 2025 08:49:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736959780; x=1737564580; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ektsrR1MXZ5eY0Ve/I0TkqM8FM2rd2jzpuGGf7fWWBE=; b=CPp5NGDUJTEONLA2CJkBKrC5i/ngdDZrBLDZn8ngaITEG59rnPhZ2eSJ9Aml3JFXtb THOa3aHkOgRklk0Ia+X/GbeO1QcL4eis9PlhwpwGLgoB+ldjkt1I0uDCHWIEjJ4oFskH qfQKzb5OtYLdFiQQNTp9H60Ad8scMEtTAlBO1pTxmfecgXmnLGP3+HxsWL+DsH55RyaR eVK/hS17+Ic9TQtU3YSf/qSTbxj8fjiu6IxT72MPLJr0P89wcD6tvLl6hkUHZ6waAKCp BdlcGypPOlhS5OAioCvl+4YQTn3Szq4lY8++9jNj5r+dBSWhMzBG1wpxLIAHLwBfY7Aq e4DA== X-Gm-Message-State: AOJu0Ywi5lFtdqNIvBo//kXo1qLnMbEr20XYjyCHWrViX7AuHc10k9bg taIWYdIBTcFrpigHDGzccgfKuQCcFNwcd3cncS33rc+/TvT55p5xWaYw3tCRkAzIpokNV86oJ6O ACJTSngya4naeHzACvOukt9wVSXCEqisrBlhw4F0ANRERB1KHp/WRX772cbSvprQQb/pOFxXu+z W30OAZX7VT/1QmkSU= X-Gm-Gg: ASbGnctwGhZ+VF4mRWK7IbN/Ekl8x00B0FNe17k69JER3llzLd1+MskN9vPW8pHQxcZ aTIdPOHlHZNk85sVtnwXt9i/AqrOG+9/URf5tBl21 X-Received: by 2002:a2e:a781:0:b0:300:3a15:8f1f with SMTP id 38308e7fff4ca-305f463be9amr98742761fa.32.1736959779767; Wed, 15 Jan 2025 08:49:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMBSizBwz8oFlfKrBPUhZZFGt/yxbRuPpiO9OP/k5ZSvXea4vWK3s4EyzD0llbAkWOzpBE9zA5rC0ecvzTkBY= X-Received: by 2002:a2e:a781:0:b0:300:3a15:8f1f with SMTP id 38308e7fff4ca-305f463be9amr98742691fa.32.1736959779395; Wed, 15 Jan 2025 08:49:39 -0800 (PST) MIME-Version: 1.0 References: <20250115125938.2699577-1-maxime.coquelin@redhat.com> <20250115125938.2699577-4-maxime.coquelin@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 15 Jan 2025 17:49:28 +0100 X-Gm-Features: AbW1kvY6tknFCyBci-t6ba4pNwEvUZjY9tHN3Ldh5FXa1MLNzrf7tgQZfmexYEc Message-ID: Subject: Re: [PATCH v2 3/4] vhost: rework async dequeue path error handling To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: McnBsck2BkF2R2-vPaMxu7pb43S-i0Jl81VJHDEIBMU_1736959780 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 15, 2025 at 5:42=E2=80=AFPM David Marchand wrote: > > On Wed, Jan 15, 2025 at 1:59=E2=80=AFPM Maxime Coquelin > wrote: > > > > This patch refactors the error handling in the Vhost async > > dequeue path to ease its maintenance and readability. > > > > Suggested-by: David Marchand > > Signed-off-by: Maxime Coquelin > > Reviewed-by: David Marchand Btw, I would squash patch 2 and 3 (especially as you updated both sync and async code at the same time in patch 4). --=20 David Marchand