From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46DABA00C4; Thu, 31 Oct 2019 17:18:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D277A1C2FB; Thu, 31 Oct 2019 17:18:48 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 1BDA01C2EA for ; Thu, 31 Oct 2019 17:18:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572538726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pu5DfM4USugQolzEH4JREYEX0yD+r4+cqXscXiQ8VcU=; b=X5rn495LXoBllvuGmEpUh0P1OVNAIsjkCpJzMx7FmQLLM3zGOufnJHOc0TBOUE0Bppyqia Zuil7Hrz41dfZXGjF5cO/8JrLb1hqGF9PIGFlErKctb9rz1DIp6lvln7zcIWAvnajTw97x 5yeMYjVw3UwvZCdsROJSwq3TPgCY8hs= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-249-CPsgxUE4PIW9pkURflSoIQ-1; Thu, 31 Oct 2019 12:18:39 -0400 Received: by mail-ua1-f72.google.com with SMTP id t13so1217143uaj.23 for ; Thu, 31 Oct 2019 09:18:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uvpjN9S7A7wbEYw2cYnQbfO45+RcKsEDx4cKVI5Dj5w=; b=nE/sjAsU98mvj3lTtj8KO+o+DNYJx7gJAW4D3BsbansRITG9iGEKY97bktQDUYv4H6 5UdqCTfEsD+8xxPjegJuRDgYSxHR9x/tz/dy5JJ7g51BsCI0+4WxlE8pF7JndusmZVjI bmPkRi4EiUsNwcQXBMa89C2zq8AZ1a/qXOy7KI9XlfjQT8G24uXaf8AlQaJXIQmucCPI kZ/6Y7UAI2OYBWEvGK1Ux6d4HAiZXKKo2Z4eaYWMEEp/RmTflRtzjFqrsL8hDl7qiy2P d3FOX1r8+e+FMq3ICqYuaBgJc0/n5IWctqXy5figcUP91GN+S3QDFVF/aRp1SZhC9XpT bvnw== X-Gm-Message-State: APjAAAXlK79nCLaJCrxhv93DxHYf7eM1hoUgNqfRi5dZruZZzltlbjlz bU/HpKmmNfn5zUdas+VRUN4GWEHMalNLzQ9cn5yowi3XLDQczpHMC6ZeZQZp+rKayDV73Eqqd5a qwUYte7FsGcWMdGy2zBw= X-Received: by 2002:ab0:2716:: with SMTP id s22mr3273420uao.86.1572538718430; Thu, 31 Oct 2019 09:18:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqyYvyChsnsw/77tYFIuQHpCWJob+A3LzLycTW71eruCnx9AqrhTOvmMMcMaQ/0ll/8pS/Xcf420UhXKKW3Ec6I= X-Received: by 2002:ab0:2716:: with SMTP id s22mr3273399uao.86.1572538717948; Thu, 31 Oct 2019 09:18:37 -0700 (PDT) MIME-Version: 1.0 References: <1568100655-20010-1-git-send-email-agalyax.babu.radhakrishnan@intel.com> In-Reply-To: <1568100655-20010-1-git-send-email-agalyax.babu.radhakrishnan@intel.com> From: David Marchand Date: Thu, 31 Oct 2019 17:18:24 +0100 Message-ID: To: Agalya Babu RadhaKrishnan Cc: dev , "Pattan, Reshma" , Hemant Agrawal , Sachin Saxena , "Parthasarathy, JananeeX M" , dpdk stable X-MC-Unique: CPsgxUE4PIW9pkURflSoIQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 10, 2019 at 9:33 AM Agalya Babu RadhaKrishnan wrote: > > From: Agalya Babu RadhaKrishnan > > 1 issue caught by 344967 > Leaked_storage: Variable sep going out of scope leaks the > storage it points to. > > When 'sep' is not null and sep_exist is 0, 'sep' is freed > before going out of scope of the function irrespective of > 'addr' exists or not. > > Coverity Issue: 344967 s/Issue/issue/ according to the contributing guide. > Fixes: e67a61614d0b ("bus/fslmc: support device iteration") > Cc: stable@dpdk.org > > Signed-off-by: Agalya Babu RadhaKrishnan Acked-by: Sachin Saxena Applied, thanks. -- David Marchand