From: David Marchand <david.marchand@redhat.com>
To: dev <dev@dpdk.org>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
David Hunt <david.hunt@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] examples: skip example when missing dependencies
Date: Wed, 10 Nov 2021 11:57:41 +0100 [thread overview]
Message-ID: <CAJFAV8xa7WRD6D=5B+j-LE4e5zoj+i56phiWYTCPB29s3YLfjA@mail.gmail.com> (raw)
In-Reply-To: <20211106085304.2376-1-david.marchand@redhat.com>
On Sat, Nov 6, 2021 at 6:54 PM David Marchand <david.marchand@redhat.com> wrote:
>
> Trying to disable the vhost library, meson will complain it can't build
> the vhost* and vdpa examples when passing -Dexamples=all.
>
> -Dexamples=all skips examples if the example itself announces it can't
> be built (for external dependencies, internal dependencies and other
> reasons).
> Since examples/meson.build will evaluate the internal dependencies
> in any case, let's move the check there and resolve the issue for
> optional internal libraries.
>
> Fixes: 0bf583222297 ("lib: allow disabling optional libraries")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2021-11-10 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 13:30 [dpdk-dev] [PATCH] " David Marchand
2021-11-05 13:39 ` Bruce Richardson
2021-11-06 8:49 ` David Marchand
2021-11-06 8:53 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-11-10 10:57 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xa7WRD6D=5B+j-LE4e5zoj+i56phiWYTCPB29s3YLfjA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).