From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F63BA034F; Wed, 10 Nov 2021 11:57:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 804874068B; Wed, 10 Nov 2021 11:57:59 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0175840683 for ; Wed, 10 Nov 2021 11:57:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636541877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KivQ+ZKtKutnNJBh4A9CWTQrNAMX3b62Xta2vcJJCjs=; b=eH5lRau7+rRVW7PpeoBxuQNAzgb0rvgydPWjmIaBesf4RqQjEtL8kIGawGtAcwEVbLhCsh 6HDrKCTOrWSOu4REnPRjUkZUYPcHzbGxv0DEgkaNdYMwqiqTAp81q9gGQzczzkFtTy7MpV 87SO36775dWvQMIwo80Zw/9Vf49UsJ0= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-4G7O9gWeOqmd16gTlSW0LA-1; Wed, 10 Nov 2021 05:57:54 -0500 X-MC-Unique: 4G7O9gWeOqmd16gTlSW0LA-1 Received: by mail-lf1-f69.google.com with SMTP id x17-20020a0565123f9100b003ff593b7c65so1089762lfa.12 for ; Wed, 10 Nov 2021 02:57:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KivQ+ZKtKutnNJBh4A9CWTQrNAMX3b62Xta2vcJJCjs=; b=brJTCPoS2XMPZKI7YV4DFE1yQ2xOVqaR2C5A/1UarhyjlCxBT6Iyy8vJBbo+ANAimo hxRC8qV+eaYJd/RkD7V/U9rtWs/LjrC5w0IwjLs53ZXbzc20Bl2EjoWNwiLmAc4F1EsX iOuQVMjg+SQKY54c1p8fFnz5dxQervDVIj3gfHdTLcck1JrcwMNpV1fOzLH9LB6YvN4Q xjd6HuqXY3Y81WKS2wcHjghQFqjcaGAB8EpEJKSNfVfStQTwOxmp/b8nArAHwPFtHxPW s63QKSPaI4kqH66xV/S6/9A2qMNe9t4vUKt3yd1GPE9lM7MrV17wiHD/V1lbEHbGMqJd 7RTA== X-Gm-Message-State: AOAM531z6NcBcsfZaW80P8Hwbo0AYqS9RTftFqhcsXwowXNGkPkLNGN2 Q9Nyr+/Xam+00ehCToqUmurqrNlEPGE+gk0eVTaJ+gA2k8SKYh8lMUNxhqmLVXUyilEJj5CLPhj S+vvHg4AT4Hy8NZivNKM= X-Received: by 2002:a2e:7f1b:: with SMTP id a27mr14427015ljd.55.1636541872774; Wed, 10 Nov 2021 02:57:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwe08L5KJJXqWECbX3l0Z5FzrEXAifPtTyaPrDjr95T4dGagt8DCwlZ9iAuLtqm+sQU6WGrM/WsjM2u5e9uKgU= X-Received: by 2002:a2e:7f1b:: with SMTP id a27mr14426991ljd.55.1636541872583; Wed, 10 Nov 2021 02:57:52 -0800 (PST) MIME-Version: 1.0 References: <20211105133055.13824-1-david.marchand@redhat.com> <20211106085304.2376-1-david.marchand@redhat.com> In-Reply-To: <20211106085304.2376-1-david.marchand@redhat.com> From: David Marchand Date: Wed, 10 Nov 2021 11:57:41 +0100 Message-ID: To: dev Cc: Bruce Richardson , "Yigit, Ferruh" , Thomas Monjalon , David Hunt , Maxime Coquelin , Chenbo Xia Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] examples: skip example when missing dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Nov 6, 2021 at 6:54 PM David Marchand wrote: > > Trying to disable the vhost library, meson will complain it can't build > the vhost* and vdpa examples when passing -Dexamples=all. > > -Dexamples=all skips examples if the example itself announces it can't > be built (for external dependencies, internal dependencies and other > reasons). > Since examples/meson.build will evaluate the internal dependencies > in any case, let's move the check there and resolve the issue for > optional internal libraries. > > Fixes: 0bf583222297 ("lib: allow disabling optional libraries") > > Signed-off-by: David Marchand > Acked-by: Bruce Richardson Applied, thanks. -- David Marchand