From: David Marchand <david.marchand@redhat.com>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
"Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>,
Phil Yang <phil.yang@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] test/atomic: fix false failures for 128-bit atomic compare exchange test
Date: Thu, 14 Oct 2021 17:28:15 +0200 [thread overview]
Message-ID: <CAJFAV8xaLOsh+NtrH+HBwYj6vY2x3EwKHZcuRhz2OdpkCDwJyw@mail.gmail.com> (raw)
In-Reply-To: <20210908174820.3485359-1-drc@linux.vnet.ibm.com>
On Wed, Sep 8, 2021 at 7:48 PM David Christensen <drc@linux.vnet.ibm.com> wrote:
>
> When checking the results of the rte_atomic128_cmp_exchange() function,
> current code compares the values of a uint32_t and a uint64_t variable.
> If the number of lcores used by the test is large, or the value of the
> iteration count N is increased, the variable size mismatch can cause a
> false test failure. Modify the comparison to compare uint64_t values.
>
> Fixes: fa3253c534b1 ("test/atomic: add 128-bit atomic compare exchange test")
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> Tested-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2021-10-14 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 17:41 [dpdk-dev] [PATCH] " David Christensen
2021-09-03 6:59 ` Ruifeng Wang
2021-09-08 17:25 ` [dpdk-dev] [PATCH v2] " David Christensen
2021-09-08 17:48 ` David Christensen
2021-10-14 15:28 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xaLOsh+NtrH+HBwYj6vY2x3EwKHZcuRhz2OdpkCDwJyw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=phil.yang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).