From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A6B2A0C4B; Thu, 14 Oct 2021 17:28:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A601411FE; Thu, 14 Oct 2021 17:28:31 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1DC0C40E50 for ; Thu, 14 Oct 2021 17:28:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634225309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WGDrRZyeebvligDTHqvy4YCAVnZ2rmx+A0vphlWy/h8=; b=fxBL+22/SVAmMm4Z+OE51mZ5Hr2ht6BBPsHpRDrz5ZOUJ/sv10fcFG05ZgdppecaY1jZPY UOL+85TFWu1lE3qXMHUQ7fPsa/JyADvoNxdakU7Bqzpf6wWzvl3S9wSWsO4Wsxm7o0mkkg 90OsHtu7awV24UackJckwjr5XfEiHoY= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-XiQTBfZ1Pj-ofTzMQScN-Q-1; Thu, 14 Oct 2021 11:28:28 -0400 X-MC-Unique: XiQTBfZ1Pj-ofTzMQScN-Q-1 Received: by mail-lf1-f71.google.com with SMTP id b36-20020a0565120ba400b003fda644089bso4620981lfv.18 for ; Thu, 14 Oct 2021 08:28:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WGDrRZyeebvligDTHqvy4YCAVnZ2rmx+A0vphlWy/h8=; b=j03uJ3NYCazbgoTlUGbC+XOA/IbH/3LDg8OmIwsWfYk8A9qCYDiVT/kROOi44hsCXK uHRPkRgoPDswylCACclEb0i6KN+gRYXKoNesEcuOI/GRCUp3mf/XvlhoTiTJt+kDRIhu HMrjreRvfarOTfScpOcKCnwq/BO6q+oajtjuqqGRJpVztdGqe1dJPNCdJ0Oelq48gYIb m9WUyi/ZoCNx0NXN4JgchSx/vYTVvtVKN9d1w+UaSkBQbIvXF6/37kdIX1FWyXZ0dD3R xpXlCVP8b3AO8Nm31NRNP7i8Cnc1DSWSoULL0YPYU2CM85n5gJTt/gRFlQPPXNKT4L79 wHbQ== X-Gm-Message-State: AOAM533pTqySa9fzqZKFDPhRvZnhv/XWtEYch6+HfiiOcw5yZxbMCaS4 ySI88xPUXDujaNA9K41OZrPvBN3zcX++wvFB32XsBaz+/S4hoEsgHnr5m+0POFhpa5Z2rFDdU2v i01PROuSuVhyyXlmASaU= X-Received: by 2002:ac2:46f8:: with SMTP id q24mr5876114lfo.484.1634225306888; Thu, 14 Oct 2021 08:28:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxftaDLnyjf1flrwd3kmnc3qvq5XmIB2MLnivsmy2foIhoYDzLIKdJtuR+Wuveox0/NoWCnDrtI54DbmHFbwig= X-Received: by 2002:ac2:46f8:: with SMTP id q24mr5876097lfo.484.1634225306723; Thu, 14 Oct 2021 08:28:26 -0700 (PDT) MIME-Version: 1.0 References: <20210902174104.3181444-1-drc@linux.vnet.ibm.com> <20210908174820.3485359-1-drc@linux.vnet.ibm.com> In-Reply-To: <20210908174820.3485359-1-drc@linux.vnet.ibm.com> From: David Marchand Date: Thu, 14 Oct 2021 17:28:15 +0200 Message-ID: To: David Christensen Cc: dev , Thomas Monjalon , "Ruifeng Wang (Arm Technology China)" , Phil Yang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] test/atomic: fix false failures for 128-bit atomic compare exchange test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 8, 2021 at 7:48 PM David Christensen wrote: > > When checking the results of the rte_atomic128_cmp_exchange() function, > current code compares the values of a uint32_t and a uint64_t variable. > If the number of lcores used by the test is large, or the value of the > iteration count N is increased, the variable size mismatch can cause a > false test failure. Modify the comparison to compare uint64_t values. > > Fixes: fa3253c534b1 ("test/atomic: add 128-bit atomic compare exchange test") > > Signed-off-by: David Christensen > Tested-by: Ruifeng Wang > Reviewed-by: Ruifeng Wang Applied, thanks. -- David Marchand