DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Ali Alnubani <alialnu@oss.nvidia.com>,
	Tejasree Kondoj <ktejasree@marvell.com>
Cc: Akhil Goyal <gakhil@marvell.com>,
	NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	 "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [pull-request] next-crypto 21.08 rc1
Date: Thu, 8 Jul 2021 22:16:17 +0200	[thread overview]
Message-ID: <CAJFAV8xaUrJHGVm87yuPJX8WWVmqo1_UXRmGNNebespt7Nv7kw@mail.gmail.com> (raw)
In-Reply-To: <DM4PR12MB51678615814B51DAE8D0944CDA199@DM4PR12MB5167.namprd12.prod.outlook.com>

On Thu, Jul 8, 2021 at 7:14 PM Ali Alnubani <alialnu@oss.nvidia.com> wrote:
> """
> $ meson --werror -Dc_args='-DRTE_ENABLE_ASSERT' --buildtype=debug build && ninja -C build
> ...
> ../../root/dpdk/drivers/crypto/cnxk/cn10k_cryptodev_ops.c: In function 'cn10k_cpt_sec_post_process':
> ../../root/dpdk/drivers/crypto/cnxk/cn10k_cryptodev_ops.c:260:37: error: 'IPV6_VERSION' undeclared (first use in this function); did you mean 'IPVERSION'?
>   260 |         RTE_IPV4_IHL_MULTIPLIER) == IPV6_VERSION);
> """

The simplest fix:

@@ -275,7 +275,7 @@ cn10k_cpt_sec_post_process(struct rte_crypto_op *cop,
                        m_len = rte_be_to_cpu_16(ip->total_length);
                } else {
                        PLT_ASSERT(((ip->version_ihl & 0xf0) >>
-                                   RTE_IPV4_IHL_MULTIPLIER) == IPV6_VERSION);
+                                   RTE_IPV4_IHL_MULTIPLIER) == 6);
                        ip6 = (struct rte_ipv6_hdr *)ip;
                        m_len = rte_be_to_cpu_16(ip6->payload_len) +
                                sizeof(struct rte_ipv6_hdr);


-- 
David Marchand


  reply	other threads:[~2021-07-08 20:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 19:30 Akhil Goyal
2021-07-07 21:57 ` Thomas Monjalon
2021-07-08  7:39   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-08  7:41   ` [dpdk-dev] " Thomas Monjalon
2021-07-08  7:47     ` David Marchand
2021-07-08  7:48     ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-08 17:13 ` [dpdk-dev] " Ali Alnubani
2021-07-08 20:16   ` David Marchand [this message]
2021-07-09  4:24     ` [dpdk-dev] [EXT] " Anoob Joseph
2021-07-09  6:43       ` David Marchand
2021-07-09  9:00         ` Anoob Joseph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xaUrJHGVm87yuPJX8WWVmqo1_UXRmGNNebespt7Nv7kw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=alialnu@oss.nvidia.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=ktejasree@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).