From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1C73A0540; Tue, 13 Dec 2022 09:58:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62E884021D; Tue, 13 Dec 2022 09:58:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C94F440146 for ; Tue, 13 Dec 2022 09:58:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670921922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cbwsZjmMfy9aScOfOqVP0hIyWIct0sqCmp0vnetQqUo=; b=WJxyNbvgHGMSlqzZnxHJv6V+XEKSaiwSsgRnz9N2NGqxSSn7nSQTTw4iPJqMCFF1py90AL BWwwlcPjAyEzNuqg6MZoqtU4dSE7Lj6XLjLqhHyVKsxO0G+VDwv1ECdTJsFExRAd3xCMOH tJR5Inak5u9gu1Bq20DsLBwsmSHsfj0= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-583-acVSCc-1NM6GjFKneKSEhA-1; Tue, 13 Dec 2022 03:58:40 -0500 X-MC-Unique: acVSCc-1NM6GjFKneKSEhA-1 Received: by mail-pj1-f72.google.com with SMTP id b6-20020a17090acc0600b0021a1a90a3e0so1599277pju.0 for ; Tue, 13 Dec 2022 00:58:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cbwsZjmMfy9aScOfOqVP0hIyWIct0sqCmp0vnetQqUo=; b=k3ix9q3AwKx0LU+Fsm6TGGkM0ynRacHgDMsnZd7iCRpCeZzJP+dBJyJc/ILwlY6NHL /ygs0Oo2XxHrm6CYnlBqnEVBJ6frYeMnCTUKuqNhjG3qz2JquLicm2CQstY//IklnIy/ FhQqA4pRxBoQFELEedQZca8VZ+Prq/oK3zKaOZuJ8nKuGOMwYBsvStT1l+bhoTc2fBO4 ZxTiu3ULX0N0hrM3uUVYQGbKlPlMX54nlkTB+JtTmSJukwAq5ImmacG6lJso2TM3tqWY uUjitx5/eQ9k7XIWRVzhCJbVS1+DGMtTasD1ZBLa7gvhcXFJnh0bQMJZ1n0yXyoEg6Ub 6rdg== X-Gm-Message-State: ANoB5pl+exYEI+8JIuqiXuuEAg6QKcq/0PF7HqCPRgv7KmUx+H942ozW +GZWoP6egBk4Rmg9eiSnfwD8RvTNkSQ4a2Zaljg3B33xyQYL2kVlP3Y8hen+d5dyrs91jQf9VTJ wwmhYSbr9iqE30dDmjTI= X-Received: by 2002:a63:4c5:0:b0:478:e150:e028 with SMTP id 188-20020a6304c5000000b00478e150e028mr11047727pge.284.1670921919679; Tue, 13 Dec 2022 00:58:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf5RX3DybGWjhXP8KURNncA7mxTOc1+jnqka+3b3Hi4UBCpmUsNIwqO10+Ou8OILUN9CCUm9hPqKyFVYezWv8qw= X-Received: by 2002:a63:4c5:0:b0:478:e150:e028 with SMTP id 188-20020a6304c5000000b00478e150e028mr11047726pge.284.1670921919331; Tue, 13 Dec 2022 00:58:39 -0800 (PST) MIME-Version: 1.0 References: <20221213075938.36964-1-changfengnan@bytedance.com> <4037650.6PsWsQAL7t@thomas> In-Reply-To: From: David Marchand Date: Tue, 13 Dec 2022 09:58:28 +0100 Message-ID: Subject: Re: [External] Re: [PATCH] eal: cleanup alarm and multiprocess hotplug before memory detach To: Fengnan Chang Cc: Thomas Monjalon , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 13, 2022 at 9:54 AM Fengnan Chang wrote: > > Thomas Monjalon =E4=BA=8E2022=E5=B9=B412=E6=9C=8813= =E6=97=A5=E5=91=A8=E4=BA=8C 16:34=E5=86=99=E9=81=93=EF=BC=9A > > > > 13/12/2022 08:59, Fengnan Chang: > > > Alarm and multiprocess hotplug still need access hugepage memory, > > > if alarm event processed after memory detach, it may cause SEGV. > > > So cleanup alarm and multiprocess hotplug before memory detach. > > > > > > Signed-off-by: Fengnan Chang > > > --- > > > lib/eal/linux/eal.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > What about FreeBSD? > > > FreeBSD may have same problem, I'll add FreeBSD in V2, before that I > want wait a few days for more comments. This fix is backport material, please add a Fixes: line. Thanks. --=20 David Marchand