DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] eal: cleanup alarm and multiprocess hotplug before memory detach
@ 2022-12-13  7:59 Fengnan Chang
  2022-12-13  8:34 ` Thomas Monjalon
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Fengnan Chang @ 2022-12-13  7:59 UTC (permalink / raw)
  To: dev; +Cc: thomas, david.marchand, Fengnan Chang

Alarm and multiprocess hotplug still need access hugepage memory,
if alarm event processed after memory detach, it may cause SEGV.
So cleanup alarm and multiprocess hotplug before memory detach.

Signed-off-by: Fengnan Chang <changfengnan@bytedance.com>
---
 lib/eal/linux/eal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 8c118d0d9f..c76f026023 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -1372,11 +1372,11 @@ rte_eal_cleanup(void)
 	eal_bus_cleanup();
 	rte_trace_save();
 	eal_trace_fini();
+	eal_mp_dev_hotplug_cleanup();
+	rte_eal_alarm_cleanup();
 	/* after this point, any DPDK pointers will become dangling */
 	rte_eal_memory_detach();
-	eal_mp_dev_hotplug_cleanup();
 	rte_eal_malloc_heap_cleanup();
-	rte_eal_alarm_cleanup();
 	eal_cleanup_config(internal_conf);
 	rte_eal_log_cleanup();
 	return 0;
-- 
2.37.0 (Apple Git-136)


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-02-13 14:11 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-13  7:59 [PATCH] eal: cleanup alarm and multiprocess hotplug before memory detach Fengnan Chang
2022-12-13  8:34 ` Thomas Monjalon
2022-12-13  8:54   ` [External] " Fengnan Chang
2022-12-13  8:58     ` David Marchand
2023-02-09 12:03 ` [PATCH v2] " Fengnan Chang
2023-02-09 12:09 ` Fengnan Chang
2023-02-09 12:45 ` Fengnan Chang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).