From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: return -1 if rte_lcore_index called from non-DPDK thread
Date: Tue, 7 Jul 2020 13:46:13 +0200 [thread overview]
Message-ID: <CAJFAV8xaiL-3sE6vA1OhqOu1Gib4Oq1ay3ovmCJxjJ-iicHBtw@mail.gmail.com> (raw)
In-Reply-To: <20200408202419.16471-1-stephen@networkplumber.org>
On Wed, Apr 8, 2020 at 10:24 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> If rte_lcore_index() is asked to give the index of the
> current lcore (argument -1) and is called from a non-DPDK thread
> then it would invalid result. The result would come
> lcore_config[-1].core_index which is some other data in the
> per-thread area.
>
> The resolution is to return -1 which is what rte_lcore_index()
> returns if handed an invalid lcore.
>
> Same issue existed with rte_lcore_to_cpu_id().
>
> Bugzilla ID: 446
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2020-07-07 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 20:24 Stephen Hemminger
2020-07-07 11:46 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xaiL-3sE6vA1OhqOu1Gib4Oq1ay3ovmCJxjJ-iicHBtw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).