From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 76DE7A0465 for ; Wed, 29 May 2019 09:59:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B0E8A49; Wed, 29 May 2019 09:59:25 +0200 (CEST) Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 4F38B1D7 for ; Wed, 29 May 2019 09:59:23 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id 94so527380uam.3 for ; Wed, 29 May 2019 00:59:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nWfqGWFQPCWbbAbyMgtEzXUaDO/F+eOefZ4zLHQrlBI=; b=BkVb0bfhPQjoB/8drYrcKEmOtIOg7BjOhG7c9N/6CupBV8sk85otZTQWhmQGq63SVq rJJrNmHgSVo48CzKVIGP3JldChB+XUgCKIrsgDfSMmyVAnu6K0xkOtHgoGXNwjNVcN0t L1whzXUPUxqfYiPH1XVxLP7KjHDibcsCFoDU3ihjxJIUqrJkYWTeMpQzD3cBy05d1B8p QwRVI2BzjeUedkegAUobejjUd/+kZSrDlwJ/RwghXaKSoiHawC1FVFXXugpQeRAZUcur kODheKMfoujdZllrLPlXNr6jhRonC4FrKwZUlDp8cKs8FDZZVF8BwcYCN1sONCPZPM3I UYaQ== X-Gm-Message-State: APjAAAXIkAQhtYY3jIXzNk6geD1A88U9bZGsGKN7c8hIynlDXA7fOqin LlYF5tQBPWNGJAjM9oUF7m8ZtJeIDpvogyo3v6FO0g== X-Google-Smtp-Source: APXvYqxtY/jBC/2h2wX40+X0wwjlI5Bacr7QGytc8prMsvmqJcVcjgXfjeEzmhEQwTEgjc6ORKSxIIiNx1CApfqhDCg= X-Received: by 2002:ab0:14a:: with SMTP id 68mr45485574uak.126.1559116762551; Wed, 29 May 2019 00:59:22 -0700 (PDT) MIME-Version: 1.0 References: <20190410083218.17531-1-olivier.matz@6wind.com> <20190521161315.25500-1-olivier.matz@6wind.com> In-Reply-To: From: David Marchand Date: Wed, 29 May 2019 09:59:11 +0200 Message-ID: To: Ferruh Yigit Cc: Olivier Matz , dev , Stephen Hemminger , Maxime Coquelin , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 00/15] prefix network structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 24, 2019 at 1:38 PM Ferruh Yigit wrote: > On 5/21/2019 5:13 PM, Olivier Matz wrote: > > The rte_net headers conflict with the libc headers, because > > some definitions are duplicated, sometimes with few differences. > > > > This patchset adds the rte_ (or RTE_) prefix to all structures, functions > > and defines in rte_net library. This is a big changeset, that will > > break the API of many functions, but not the ABI. > > > > This was discussed in [1], and requested by the techboard [2]. > > > > patch-v1: > > * rease on top of v19.05 > > * remove uneeded renames in drivers/net/bonding/rte_eth_bond_pmd.c > > and app/test-pmd/icmpecho.c (arp-related variables) > > * do not modify base drivers, except cxgbe, thunderx, enetc, qede: > > only files that already contain dpdk definitions are modified. > > * fix checkpatch issues when it does not impact the code style too > > much. Big warnings remain about the RTE_IPv4() macros because > > arguments are separated by ',' instead of ', '. > > * add a release note patch > > * tested compilation on x86_64-linux and x86_64-freebsd. > > > > rfc-v2: > > * rebase on top of v19.05-rc1 > > > > > > [1] http://mails.dpdk.org/archives/dev/2018-January/087384.html > > [2] http://mails.dpdk.org/archives/dev/2019-February/125033.html > > > > > > Olivier Matz (15): > > net: add rte prefix to arp structures > > net: add rte prefix to arp defines > > net: add rte prefix to ether structures > > net: add rte prefix to ether functions > > net: add rte prefix to ether defines > > net: add rte prefix to esp structure > > net: add rte prefix to gre structure > > net: add rte prefix to icmp structure > > net: add rte prefix to icmp defines > > net: add rte prefix to ip structure > > net: add rte prefix to ip defines > > net: add rte prefix to sctp structure > > net: add rte prefix to tcp structure > > net: add rte prefix to udp structure > > doc: announce network api change > > Reviewed-by: Stephen Hemminger > Reviewed-by: Maxime Coquelin > > For series, > Reviewed-by: Ferruh Yigit > > Series applied to dpdk-next-net/master, thanks. > Sorry, late to the party... Since we change those defines, we might as well avoid these warnings: CHECK:CAMELCASE: Avoid CamelCase: CHECK:CAMELCASE: Avoid CamelCase: I can send a patch. -- David Marchand