From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05D62A04B1; Wed, 4 Nov 2020 18:41:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 216E32BE1; Wed, 4 Nov 2020 18:41:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 70BF72BD3 for ; Wed, 4 Nov 2020 18:41:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604511684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dICfKcRmZnj5t48fFAUUPIbaoZxdEfU7hjPApe+OUrk=; b=LrzIO4LNIsXzPpZ4MVqg6GTbfKD4tlTpkmpaslTQk2ASWmdFlF71RxFz5Ih0g3r9JCk/lN ozi3HGgS1jPQ9z8CNRxtAtlU0LntUSmFHJvYQeSR1IyN+XipPhtrCBY+c6p4PCEF2IMjwm WBMtiXSLNKFG2pyeGpBUxa4B9kfFtus= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-356-7Ocx6KbyPz6vIf2-18JVYA-1; Wed, 04 Nov 2020 12:41:23 -0500 X-MC-Unique: 7Ocx6KbyPz6vIf2-18JVYA-1 Received: by mail-vk1-f198.google.com with SMTP id s6so3811737vkg.12 for ; Wed, 04 Nov 2020 09:41:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dICfKcRmZnj5t48fFAUUPIbaoZxdEfU7hjPApe+OUrk=; b=CaH5Kznun+INmc/TiPEE9L1rkTnMAhtJh3VvZwxJnz7zQpgLP0YOeVIuCCYwQhs5Se qt+fcz6KLxoSWzh61eIYAYMNRXultNPgsZs88b+JqkNUFNPzHbMpiBO3+ZosSPOcvqte E/gtUg4ZbNbTqgbGur7zGmMMsUXTT2NghfXzdWcPVJ7gFb/dbychXcLgmZ3EcU+euTcK b94btp+rWC3UtBwEnrm9xIbuyutp5ZV8EbnOgE8jp8beHCF7k0PjbEvjv+K4g223x3K0 GzYSXRBC3G3+xrFSSe0AikPGMXQ27VqVXEfFJI1ttaKTYoOmjx1W3sZdwSqWV89AVTe7 8kaQ== X-Gm-Message-State: AOAM530qlzYdyrlHyCDhJt/7axnEZEW9HhCl0pii5MldRVUs8xIN2uvE kGG/q1ag/IlAoWL7zQKbS6wHcxkzOkIZ0Ukih0oKSJpWPOinFaLrh5V6G9RC4FRTGPR13WHhYOz Mvnj3KGxCM4Iqe34CfVQ= X-Received: by 2002:a67:fd46:: with SMTP id g6mr9472273vsr.27.1604511682691; Wed, 04 Nov 2020 09:41:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJyu+EMAqQsm/ywzqGvt1tqFvPjivpmKX19Rf+9FwAvg/0Sf9nqP1UTZ4MXjW6hIrmk8vFdnkPza4pV3Jdvareg= X-Received: by 2002:a67:fd46:: with SMTP id g6mr9472261vsr.27.1604511682503; Wed, 04 Nov 2020 09:41:22 -0800 (PST) MIME-Version: 1.0 References: <20201024004331.25043-1-stephen@networkplumber.org> <20201104162000.9419-1-stephen@networkplumber.org> <20201104162654.GK1898@platinum> In-Reply-To: <20201104162654.GK1898@platinum> From: David Marchand Date: Wed, 4 Nov 2020 18:41:11 +0100 Message-ID: To: Stephen Hemminger Cc: dev , Olivier Matz Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5] mbuf: allow dynamic flags to be used by secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 4, 2020 at 5:27 PM Olivier Matz wrote: > On Wed, Nov 04, 2020 at 08:20:00AM -0800, Stephen Hemminger wrote: > > The dynamic flag management is broken if rte_mbuf_dynflag_lookup() > > is done in a secondary process because the local pointer to > > the memzone is not ever initialized. > > > > Fix it by using the same checks as dynfield_register(). > > I.e if shared memory zone has not been looked up already, > > then discover it. > > > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger > Acked-by: Olivier Matz Applied, thanks. -- David Marchand