From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 009494610D; Wed, 29 Jan 2025 15:17:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C75EC402AE; Wed, 29 Jan 2025 15:17:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1C81F40274 for ; Wed, 29 Jan 2025 15:17:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738160226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GfVjEOaEditN/2BgvYh+EyQpqLwC0Ryg6//P2fu2YJA=; b=Shc/YFlqmZaMy6PjfVUBcrnoP7ZNSormFUwTuC/G2lK8Jmf6sUD88xiJgHaooFfQuEcfF1 hRX4hmGNuSAdMSVMuFIjCmkIJyRFuLHOCsKlH8c6lq/jNX6/a6DDCmCAMWA8sZmi+LKWlS wY4h9U53PIMpoWuXm2PWUh8pUEwEugs= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-ApXyAL8hOqKCZtLXMwUaQw-1; Wed, 29 Jan 2025 09:17:05 -0500 X-MC-Unique: ApXyAL8hOqKCZtLXMwUaQw-1 X-Mimecast-MFC-AGG-ID: ApXyAL8hOqKCZtLXMwUaQw Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5401f43232cso3560585e87.1 for ; Wed, 29 Jan 2025 06:17:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738160223; x=1738765023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfVjEOaEditN/2BgvYh+EyQpqLwC0Ryg6//P2fu2YJA=; b=r8umT0iuP43MWCEBN9nRYY8CZHK/LxebktQjQ5XSBBqQENmfTULgsr7NALr1xl4F3v O5oL41YRMRWSIpGkDi2+BEZwJw96qZsIFBAuRaRg3YvEH+nJDp/yuJXUrKhKmiyclmyV U5hbVnMumtFXROlR1h3Cm6O+C+ggvb6xve9ksiWueN0JhJ6ZMcAiggiyOfUnFq/k8Inu Qkej72v8DCeUIDln0WYZnkIueyhyzi0GWkPM3iIqsrxAl1m+RPZIk2wih31+34VVW/rn XwySFED20Z6lq2RTSuHcLYG9K3sl4vt94ZY6FkyWfkfxT6BQptogHuIgNWfeIhvF7k+h o97g== X-Gm-Message-State: AOJu0Ywi9REjEt64S7Gfb/E/F+0Hs4nbgMtGWsstWCdRXdmv0c+rgutf cpgssdWkPCBpPfZgRfHU3U68hgmW+XLccRYvW3e1/f5a53HcFyg0BzWB14Naqvf1/ygY17Y6SU7 QwYDsgw7FJdW0oCKLpcDn1LGZOhPqeqA8aMRdW/nJmqhATIQtYLsjf/Wibuema6qC7JRzRaCTS+ Fn4QsPwGeWNoT3XOk= X-Gm-Gg: ASbGncvaBZAxLjl0Th5LhBkCnS3iVlBWKe8yiiakUnQBnZgOnFcJFqyEHviN2hRB4NB VAqoBHtrLH57cbHlHDd4aA805I6Z8aprbda2hjzgEthbLAae3qh/Rllxq82KQogoo X-Received: by 2002:a05:6512:1254:b0:542:63a8:393f with SMTP id 2adb3069b0e04-543e4be9ba4mr926544e87.14.1738160223508; Wed, 29 Jan 2025 06:17:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IFfpvLRvOKyCZXP7lKhQnboU4Tlk3iEILoLRCI236QSUgq4gqzAkoVyAyYLPS1E6+AXKdsPONNM7rmSF5UqM9o= X-Received: by 2002:a05:6512:1254:b0:542:63a8:393f with SMTP id 2adb3069b0e04-543e4be9ba4mr926538e87.14.1738160223112; Wed, 29 Jan 2025 06:17:03 -0800 (PST) MIME-Version: 1.0 References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> <1737498970-4631-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: From: David Marchand Date: Wed, 29 Jan 2025 15:16:51 +0100 X-Gm-Features: AWEUYZkTGWcfsgjuWbMbdBPL1o-d3A_qpztRBFv21355G19vdr0_wr0Zfkm52_I Message-ID: Subject: Re: [PATCH v16 0/3] add diagnostics macros to make code portable To: Andre Muezerie Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Thomas Monjalon , Raslan Darawsheh X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _ge4sFU-rLWOExESSE5JiVanK2_UaP2N-XNLG0ZyMXM_1738160224 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 29, 2025 at 2:26=E2=80=AFPM David Marchand wrote: > > On Tue, Jan 21, 2025 at 11:36=E2=80=AFPM Andre Muezerie > wrote: > > > > v16: > > * Updated comment for RTE_CAST_PTR. > > > > v15: > > * Fixed a comment in rte_common.h to make Doxygen happy. > > * Fixed a typo (extra comma). > > * Added missing RTE_PTR_UNQUAL needed for ARM64. > > > > v14: > > * Renamed RTE_PTR_DROP_QUALIFIERS into RTE_PTR_UNQUAL to more resemble > > C23 typeof_unqual. > > * Added macro RTE_CAST_PTR to make the cast more readable when removin= g > > a type qualifier from a pointer. > > > > v13: > > * Renamed RTE_IGNORE_CAST_QUAL into RTE_PTR_DROP_QUALIFIERS. > > * Added (void *) cast to RTE_PTR_DROP_QUALIFIERS to avoid the need > > for casting the result in most places where the macro is used. > > > > v12: > > * Added macro RTE_IGNORE_CAST_QUAL and used it as a more compact and > > readable form to suppress warnings where a cast is used to remove > > a type qualifier. > > > > v11: > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > it was needed. > > > > v10: > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > it was needed. > > > > v9: > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > it was needed. > > > > v8: > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > it was needed. > > > > v7: > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > it was needed. > > > > v6: > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > it was needed. > > > > v5: > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > it was needed. > > > > v4: > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > it was needed. > > > > v3: > > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > > it was needed. > > > > v2: > > * Removed __rte_diagnostic_ignored_wstrict_aliasing (introduced > > in v1). > > * Removed the pragmas from many files where they were not needed. > > * In the files where the pragmas were indeed needed, reduced the > > scope during which they are active, reducing the chance that > > unforeseen issues are hidden due to warning suppression. > > > > Andre Muezerie (3): > > eal: add diagnostics macros to make code portable > > drivers/common: add diagnostics macros to make code portable > > drivers/net: add diagnostics macros to make code portable > > I moved a bit the casting macros in rte_common.h (and put them next to > RTE_CAST_FIELD). > Thanks for this work Andr=C3=A9, series applied. CI is not happy with those changes on ppc64le (this was caught by OBS after pushing). See, for example, https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Fedo= ra_Rawhide/ppc64le Please send a fix. --=20 David Marchand