From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2651A00BE; Wed, 30 Oct 2019 11:14:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4878A1BFC9; Wed, 30 Oct 2019 11:14:36 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 4E0B81BFC7 for ; Wed, 30 Oct 2019 11:14:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572430474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=66A6H7jHExKfIIhu8yp+Z5GBeu58gUBC84n5DpgEDhM=; b=cUKC8aCmL1OFJweaD/wQFBh9UxI56qK4/jR8+Kg8bLz31o7CBzwV5xCzcQx/w5d5rJKHs7 wIgriNIsaLkEV9MvKsTlKRifroW02QQkTU1+Wq1ueK5UD26GwRWCE+UYkKyr72SQmfBe29 WPTl918yMviaCBqOaLXATPU7aj78NHw= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-A5nJcSKmMUmmahQScxb0Ng-1; Wed, 30 Oct 2019 06:14:33 -0400 Received: by mail-ua1-f70.google.com with SMTP id q34so299424uad.13 for ; Wed, 30 Oct 2019 03:14:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6W5+zGUb/Llz/t98kQnrmJeR5893Og2+q8s7FjazXSY=; b=geqtDKPEs90alVtGPuCRwSlmdLftoH35a7bQMiDOlS/eB4ibzqvyY9G8QFiH8ydtTY WkXGN/kyxvkgAOXHYasRdDiEXq7PfmO3OPdo+WWtmR3g3DPO0mrpDbm3jAD+AAvEWMc1 3YHPrxzb2xMi0xNC1Od5fts+JKhM78GB15ZrYmxlI0B0INzmbvJM16Hz5rQttro6BcZ6 E2RJLzAdo7qoGyHFWCPMrPgACWjPSIGvFBU06Evy2Nuuucsx2AnYfj3T0R4ec9Ii1JnF SJeZPx342s4i9ElwygE6xapehszYsj/10sotdoaANw1I1ua5ljCeAZG0iMqK6NHDLqyy 8Plg== X-Gm-Message-State: APjAAAW+TrStNgWKmfASKu6VrPvrqQEHCvfRGk+MTaPRpYc8WNOgrcMU 8Fe9FMAo7zIvLbVwVF7/z4GvsCN+B/jtleOurxA61uIAd18tQP1iQGD6viWTBJI/KDqBFbnWO0w yTEKTGIfCIOZNlPJ4Jv0= X-Received: by 2002:a05:6102:531:: with SMTP id m17mr4492724vsa.105.1572430472407; Wed, 30 Oct 2019 03:14:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqwa33vHYiseJIvdUjdtMm5qv8A203CXI3shzg3RkHu9JJyJ8l7vk0sUPlnnoJC4alevVkpo1niqPRH6COLWPBo= X-Received: by 2002:a05:6102:531:: with SMTP id m17mr4492699vsa.105.1572430471825; Wed, 30 Oct 2019 03:14:31 -0700 (PDT) MIME-Version: 1.0 References: <20191004111106.30267-1-nipun.gupta@nxp.com> In-Reply-To: From: David Marchand Date: Wed, 30 Oct 2019 11:14:20 +0100 Message-ID: To: Nipun Gupta , Hemant Agrawal Cc: dev , "Yigit, Ferruh" , Sachin Saxena , Thomas Monjalon X-MC-Unique: A5nJcSKmMUmmahQScxb0Ng-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] config: disable iova phys for dpaa and 1588 for dpaa2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 30, 2019 at 10:37 AM Nipun Gupta wrote: > > Hi David, > > > -----Original Message----- > > From: David Marchand > > Sent: Sunday, October 27, 2019 4:33 PM > > To: Nipun Gupta > > Cc: dev ; Yigit, Ferruh ; Hemant > > Agrawal ; Sachin Saxena > > ; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PATCH] config: disable iova phys for dpaa and = 1588 > > for dpaa2 > > > > On Fri, Oct 4, 2019 at 1:26 PM Nipun Gupta wrote: > > > > > > IOVA_PHYS flag is not required in the DPAA config, thus disable it. > > > Also, disable the 1588 timer support by default on DPAA2 platform > > > due to the performance impact > > > > With this patch, we don't have a single target using the 1588 timer sup= port. > > This means that it will get broken in the future. > > > > Is this used? > > Yes, this is enabled when PTP client application is used. We have by defa= ult disabled it > because it has performance implications. We enable it in our system testi= ng from time to > time basis. Ok, but beware that, starting from now, we (maintainers) won't see that the compilation gets broken with this feature enabled. Hope you can catch issues quickly. > > With this patch, the meson configuration is unaligned with the make > > configuration. > > I am not sure if I get this. In meson build as you mentioned: > - config/meson.build:dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true= ) > - config/arm/meson.build: ['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]] > > And in Makefile: > config/common_base: CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dy > config/defconfig_arm64-dpaa2-linuxapp-gcc:CONFIG_RTE_LIBRTE_DPAA2_USE_PHY= S_IOVA=3Dn > > And now we have: > config/defconfig_arm64-dpaa-linuxapp-gcc:CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS= _IOVA=3Dn > > Can you please let me know if I need to make any change for meson build. You updated the configuration for the dpaa machine in make. config/arm/meson.build: ['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]] only applies to dpaa2. So in meson, the dpaa machine still has RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dy > > > > > If I look before the patch: > > > > origin/master:config/meson.build:dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_ > > PHYS_IOVA', > > true) > > origin/master:config/arm/meson.build: > > ['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]] > > > > origin/master:config/common_base:CONFIG_RTE_LIBRTE_DPAA2_USE_PHY > > S_IOVA=3Dy > > origin/master:config/defconfig_arm64-dpaa2-linuxapp- > > gcc:CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dn > > > > And in the history, I understand: > > - option (with dpaa2 in the name) introduced and enabled for all > > - later, disabled for dpaa2 > > > > Does it mean the option can be removed? > > Here again, we use this option when running DPDK in Virtual Machine (Dire= ct Assignment). > By default this option is disabled, but for VM scenarios we use this opti= on extensively. I don't understand when or on which platform you want this enabled/disabled= . If this option is supposed to be disabled by default, then the value in those files (below) should be changed to n/false. config/common_base:CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dy config/meson.build:dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true) doc/guides/nics/dpaa2.rst:- ``CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA`` (default ``y``) And then, we end up in the same situation than described above with no configuration referencing this option enabled. Please clarify. -- David Marchand