From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Matan Azrad <matan@nvidia.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup
Date: Thu, 14 Jan 2021 09:34:16 +0100 [thread overview]
Message-ID: <CAJFAV8xbtAPrZdv4kJcUs85fDdfAvRpmnsdGP=C0DAYsWbbzFw@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zi8aYPryqA2W4XUH9O-wxP=8RKGB3F=6+7dVyjmrRa9Q@mail.gmail.com>
On Fri, Jan 8, 2021 at 9:48 AM David Marchand <david.marchand@redhat.com> wrote:
> > I wonder if it would be possible and cleaner to disable cancellation on
> > the thread while the mutex is held?
>
> +1
IEEE Std 1003.1-2001/Cor 2-2004, item XBD/TC2/D6/26 is applied, adding
pthread_t to the list of types that are not required to be arithmetic
types, thus allowing pthread_t to be defined as a structure.
It would be better to leave pthread_t alone and not interpret it:
if (priv->timer_tid) {
pthread_cancel(priv->timer_tid);
pthread_join(priv->timer_tid, &status);
}
priv->timer_tid = 0;
--
David Marchand
next prev parent reply other threads:[~2021-01-14 8:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 6:43 [dpdk-dev] " Matan Azrad
2021-01-07 18:09 ` Maxime Coquelin
2021-01-08 8:48 ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-01-14 8:34 ` David Marchand [this message]
2021-01-14 11:49 ` Matan Azrad
2021-01-14 12:38 ` Maxime Coquelin
2021-01-14 13:09 ` Matan Azrad
2021-01-14 14:27 ` Maxime Coquelin
2021-01-14 15:23 ` Matan Azrad
2021-01-21 10:46 ` Maxime Coquelin
2021-01-21 20:13 ` Matan Azrad
2021-01-26 10:22 ` Maxime Coquelin
2021-01-26 10:45 ` Matan Azrad
2021-01-26 13:00 ` Maxime Coquelin
2021-01-26 18:23 ` Matan Azrad
2021-01-27 10:45 ` [dpdk-dev] " Maxime Coquelin
2021-01-27 12:01 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xbtAPrZdv4kJcUs85fDdfAvRpmnsdGP=C0DAYsWbbzFw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).