From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CA25A0597; Thu, 9 Apr 2020 10:27:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 75AE61C1B9; Thu, 9 Apr 2020 10:27:00 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 2BFD01C1AD for ; Thu, 9 Apr 2020 10:26:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586420818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a/pgxvsvW4hvZgPfe+9lLCZ8qv62vTiJBZ91EKD79hU=; b=iTJXRdmM4OgxdEGQrhGdnmX1+tGGNuwV/6yUK7W5J9b0Ei9uxSvCj0TMbMzapbkVpL+j8p LsgE/WzUZnjEXPifDooL+9w+0SEuNOiHxNzgaC8Qni/VE4LFdjzOUEzW/RO+zE7kpnuGXY s9SPyEyjwha4KcDlu2Q35LLgf7QvuWQ= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-265-hnkea0G1MUq9Hx98EN65UA-1; Thu, 09 Apr 2020 04:26:55 -0400 X-MC-Unique: hnkea0G1MUq9Hx98EN65UA-1 Received: by mail-vk1-f199.google.com with SMTP id s62so3818783vks.7 for ; Thu, 09 Apr 2020 01:26:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xzyVuw+rFrIRwzhHeQOiyh3sGfGUiuSC1rq3wM9Dp1A=; b=KlpAmFfBG3a6Td8k7o4I0nA2pgY6LYN5x1WasOgff9jqPFtAhgLwc9sDX5IwXE/F/1 1EEdQsWp3NdCC6AXTAt/oO/jbi9ULXcpOC/ebBncpvN7R4KDQroiLjE+hfDlscCuh4Rh TWOTIk9BIdwr1oaBAcvqAPFrJ3t41B4Ig3elod62fif0vVe+Y1b/N3t5L0+okUqbivjG kTp3kARx2NIWUrcXOZcpKnFgG8Q51+sNYo8eP9hZQR6VF06/Iz7hPuv6ntg65257JmTd 5mUfCNORJVvG4HUT36mU2tQLtah37zpjrzzUzfy5oLXvi1z1mAodFsIRonbugo3RWnzP 9CrQ== X-Gm-Message-State: AGi0PubAktHoj8s3EOI5SCruSGfesNd5IHg5mBBIS2zNjup/N5OY74Wj WuDOLIcDBXXee7MnR7VhcNc+6KSTIAVyBvIJl/AqP2f1iZ3i0sAOI5MVhjGHElQEKp/m5gj5E+E myNOx/SAKHAW28HVuTDw= X-Received: by 2002:a9f:2204:: with SMTP id 4mr8378129uad.87.1586420814646; Thu, 09 Apr 2020 01:26:54 -0700 (PDT) X-Google-Smtp-Source: APiQypKX7jjNigCAJDpW645lJJLLMvd6Pfn16zacZhEXhxQY+ZYmweVvcKal6CMZ2qoMnfMDBEpusevBMBH9+weRxcs= X-Received: by 2002:a9f:2204:: with SMTP id 4mr8378122uad.87.1586420814454; Thu, 09 Apr 2020 01:26:54 -0700 (PDT) MIME-Version: 1.0 References: <20200407224758.57459-1-thomas@monjalon.net> In-Reply-To: <20200407224758.57459-1-thomas@monjalon.net> From: David Marchand Date: Thu, 9 Apr 2020 10:26:43 +0200 Message-ID: To: Thomas Monjalon Cc: dev , ivan.malov@oktetlabs.ru, Andrew Rybchenko , Stephen Hemminger , dpdk stable , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] log: fix level picked with globbing on type register X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 8, 2020 at 12:48 AM Thomas Monjalon wrote= : > > When a log type is registered, the level can be picked > by matching saved options. > The check of fnmatch globbing result was reversed. > > The same bug was already fixed in a similar function. > This one is acting in log type register function. > > Note: this function rte_log_register_type_and_pick_level() > is not used a lot and could be merged with rte_log_register(). Same fix as a patch I sent quite some time ago and left behind.. https://patchwork.dpdk.org/patch/57742/ I left it in a series I wanted to work on later... Anyway, this fix is needed. I suppose we are missing a unit test too. --=20 David Marchand