From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A558FA04DD; Wed, 18 Nov 2020 15:11:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C392C910; Wed, 18 Nov 2020 15:11:03 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id A435CC8DC for ; Wed, 18 Nov 2020 15:11:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605708659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pPwlOqBon831hahaFCkTEKrKkdr/6b3iqtPwO/Xxyrs=; b=dTj/LMm6Aw/IYsjFNzQyCPmNjxiikGMWytPCGd0lDgPr3B5AmTh5JFPqBuBgTgj9j2oNJ+ tfQkv64JwdApqUvOLx/RlaAE1Il7R1RzQY5u5KpJ+CCJAlb//+uxacR5achgwNXDpCF/FL IFCkq3ST5tmVEmG7Q94XAN3jkyfPWUY= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-51-dgXLgT8iPwKoZ2TEwT0TnQ-1; Wed, 18 Nov 2020 09:10:56 -0500 X-MC-Unique: dgXLgT8iPwKoZ2TEwT0TnQ-1 Received: by mail-ua1-f72.google.com with SMTP id 102so541189uak.8 for ; Wed, 18 Nov 2020 06:10:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pPwlOqBon831hahaFCkTEKrKkdr/6b3iqtPwO/Xxyrs=; b=U65Gn0wEYvudid7J11xh/T7qqTXdBmOXqCnKISp4MmHO9NK9n08Q6AYjF1WmFEJgIZ hILXPJC64JaD4J3zekox4yPhTNxHiDXcXUgNRDvN3IoxiBJGFemA1fzvDGlRE4+j2TaC HC6NRXhXycWwM236sY+nC+Ar3/JUXlO59R3N6uxdUoroe+NzhBV0KbD7oo9bJwId5LpZ KszYsDhoOftr+9qeIOVMGnfWiS+vYgX1i4anEs7yV189q4pu+pEIw6EiFHdE0SFm8f8a AJfrgqetTwywiGbkYvbnPRKkQs3x95iuUBiLkymPpMeZTfAoEmxt7HcKwUidzKqK6qbA 1uqw== X-Gm-Message-State: AOAM530ww5tdLKMdgVe/z1zD1gAX6m+fnm8TJBJAcBEhBHNs4ikdLEPS 2vPOae8aFoDHLdF6Mwd9VYYZBbquAb7BBsZYPVG73uSj9Zm/KJTzHgtco0X+VzpKY4Km8G4Kwuo fdBRczgN1zzoZE5ltksc= X-Received: by 2002:a1f:23d6:: with SMTP id j205mr2977285vkj.20.1605708653858; Wed, 18 Nov 2020 06:10:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5CqNqcz1MqUihaBNQJMnxdwiXqOoI31lqbwggC54EV5OgTkRL1L53IIoAuMQX6Pbw1LkNp3MId7ZtJ0GmLE8= X-Received: by 2002:a1f:23d6:: with SMTP id j205mr2977252vkj.20.1605708653497; Wed, 18 Nov 2020 06:10:53 -0800 (PST) MIME-Version: 1.0 References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> <20201118114525.99053-4-ferruh.yigit@intel.com> In-Reply-To: <20201118114525.99053-4-ferruh.yigit@intel.com> From: David Marchand Date: Wed, 18 Nov 2020 15:10:42 +0100 Message-ID: To: Ferruh Yigit Cc: Maryam Tahhan , Reshma Pattan , John McNamara , Vipin Varghese , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 3/7] app/procinfo: remove suspicious sizeof X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 18, 2020 at 12:46 PM Ferruh Yigit wrote: > > The intention with the "sizeof(0)" usage is not clear, but the 'stats' > already 'memset' by 'rte_cryptodev_stats_get()' API, removing 'memset' > in application. > > Fixes: fe773600fe3e ("app/procinfo: add --show-crypto") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > app/proc-info/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c > index c11fe25af4..dc5cc92209 100644 > --- a/app/proc-info/main.c > +++ b/app/proc-info/main.c > @@ -1207,7 +1207,6 @@ show_crypto(void) > > display_crypto_feature_info(dev_info.feature_flags); > > - memset(&stats, 0, sizeof(0)); > if (rte_cryptodev_stats_get(i, &stats) == 0) { > printf("\t -- stats\n"); > printf("\t\t + enqueue count (%"PRIu64")" > -- > 2.26.2 > Reviewed-by: David Marchand -- David Marchand