From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4847742354; Fri, 13 Oct 2023 09:07:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BE43402A1; Fri, 13 Oct 2023 09:07:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4CA854028C for ; Fri, 13 Oct 2023 09:07:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697180837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bc0qS3AGcVCIZuBjTC5X1VrWuQTgI+BRRh48n1a+c8U=; b=UCBx77DaAAAaeU1JDoD49xgZ91DXDWgCpCBdqBJcAFGiKDaoJrY5mu1wTN4VjwB63KbMJo wYAXYxVTh+cJ3b/aMNS6AGYRpZUaceEjYUgNs4bvTMnvr8KUjvOoj2UHV3U3WAzfu1eXAH n6baGChStnUL3oyuYhBxQNOt2royBLg= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-OLHn5nZXMXaG7WCuVNt82w-1; Fri, 13 Oct 2023 03:07:16 -0400 X-MC-Unique: OLHn5nZXMXaG7WCuVNt82w-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c2845cc163so15944891fa.2 for ; Fri, 13 Oct 2023 00:07:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697180835; x=1697785635; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bc0qS3AGcVCIZuBjTC5X1VrWuQTgI+BRRh48n1a+c8U=; b=WW7+jJtxDb3+FVeIZUvWS0cXcagrse1ovnDZ8HRtrPNdEnFEOAWmz4EpqVuKaVouwe tmZLyocVpnsA0+pgpnMCVHIKCVXdVBiiZFbKg98ZPzW0XsdP2K6MZVlT1I0Z+eERg/an lPiXav3P/Vaw1lj2Z5DPH6NfRAm7N7IKh9TaJ87Lpj066U0jIKAK+hjlZHz8/lp7tNHu vXdIrrIeIkT8YceaaoulsLpByHYUVqDo38F+B2mHHliems7b5iaIn0X8b4jvV+l3Vl8s NMjlYRCsL86cXSpLSZyZ4KYt2N3ZJtHRuNk9pWcO2fVwqi8uawcYX5IfObl+wBtrH8s/ bL3w== X-Gm-Message-State: AOJu0YywSS4rmZyG3ypjqYZwlPJJD1koDsww+1Ucir4Z+/q98A6z9Gou h0Md31e9OAnfKIPifzFs/DFiGpamr8QSMZrX4zIfzZ5fDzOlYqVJszjprY3oxzZhbKjq2/dUUlW btAHBdhc5NLThZeRf+tk= X-Received: by 2002:a05:651c:b2c:b0:2c5:380:2a10 with SMTP id b44-20020a05651c0b2c00b002c503802a10mr1813267ljr.25.1697180834999; Fri, 13 Oct 2023 00:07:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHWa2JN5hmHsafU9v27AaAKiHE4KNYxPCsvXvnbEMCQLKnGOaseRQTkcAXiIqmcSeozW+5Gw+lNXloP1AtXw1A= X-Received: by 2002:a05:651c:b2c:b0:2c5:380:2a10 with SMTP id b44-20020a05651c0b2c00b002c503802a10mr1813250ljr.25.1697180834692; Fri, 13 Oct 2023 00:07:14 -0700 (PDT) MIME-Version: 1.0 References: <20231013042722.429592-1-taozj888@163.com> In-Reply-To: <20231013042722.429592-1-taozj888@163.com> From: David Marchand Date: Fri, 13 Oct 2023 09:07:03 +0200 Message-ID: Subject: Re: [PATCH v2 0/3] example/l3fwd: relax l3fwd rx RSS/Offload if needed To: Trevor Tao Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Fri, Oct 13, 2023 at 6:28=E2=80=AFAM Trevor Tao wrote= : > > This series tries to relax l3fwd rx RSS/Offload mode requirement if they > are not supported by underlying hw or virtual devices, there is an > option named relax_rx_mode added to enable this option. > > Trevor Tao (3): > examples/l3fwd: relax RSS requirement with option > examples/l3fwd: relax the Offload requirement > doc: add a relax rx mode requirement option > > doc/guides/rel_notes/release_23_11.rst | 251 +++++++++++++++++++++--- > doc/guides/sample_app_ug/l3_forward.rst | 4 +- > examples/l3fwd/l3fwd.h | 12 +- > examples/l3fwd/l3fwd_em.h | 2 +- > examples/l3fwd/l3fwd_lpm.h | 2 +- > examples/l3fwd/main.c | 30 +++ > 6 files changed, 272 insertions(+), 29 deletions(-) Thanks for the patches. One comment on the form though. I see 4 batches of "v2 patches" in patchwork. https://patchwork.dpdk.org/project/dpdk/list/?submitter=3D3044&state=3D* I marked all but the last batch as superseded. If there is something wrong with this, please register to patchwork with your mail address, you will then be able to update the states yourself. It is hard to follow what work has been done between those different iterations of patches. For future submissions, don't forget to version your patches with a new revision (iirc, we should be at version 7 if I count the initial standalone v1 patch). In the cover letter, please provide a changelog of the differences between revisions. If you think it is better, you may put a more detailed changelog in each patch commitlog (as annotations, after ---). Thanks. --=20 David Marchand