* [PATCH] net/ice: fix segmentation fault Rx function
@ 2025-01-30 19:26 Vladimir Medvedkin
2025-01-31 10:43 ` David Marchand
2025-01-31 15:28 ` Andre Muezerie
0 siblings, 2 replies; 4+ messages in thread
From: Vladimir Medvedkin @ 2025-01-30 19:26 UTC (permalink / raw)
To: dev; +Cc: anatoly.burakov, bruce.richardson, andremue
Fix a typo in avx512 rx function, where accidentally the _mm_load_si128
argument was passed by value instead of a pointer.
Fixes: 43fd3624fdfe ("drivers: replace GCC pragma with cast")
Cc: andremue@linux.microsoft.com
Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
drivers/net/intel/ice/ice_rxtx_vec_avx512.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/intel/ice/ice_rxtx_vec_avx512.c b/drivers/net/intel/ice/ice_rxtx_vec_avx512.c
index 681b31f61f..bd49be07c9 100644
--- a/drivers/net/intel/ice/ice_rxtx_vec_avx512.c
+++ b/drivers/net/intel/ice/ice_rxtx_vec_avx512.c
@@ -474,7 +474,7 @@ _ice_recv_raw_pkts_vec_avx512(struct ice_rx_queue *rxq,
(RTE_CAST_PTR(const __m128i *, &rxdp[7].wb.status_error1));
rte_compiler_barrier();
const __m128i raw_desc_bh6 = _mm_load_si128
- (RTE_CAST_PTR(const __m128i *, rxdp[6].wb.status_error1));
+ (RTE_CAST_PTR(const __m128i *, &rxdp[6].wb.status_error1));
rte_compiler_barrier();
const __m128i raw_desc_bh5 = _mm_load_si128
(RTE_CAST_PTR(const __m128i *, &rxdp[5].wb.status_error1));
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/ice: fix segmentation fault Rx function
2025-01-30 19:26 [PATCH] net/ice: fix segmentation fault Rx function Vladimir Medvedkin
@ 2025-01-31 10:43 ` David Marchand
2025-01-31 11:21 ` Bruce Richardson
2025-01-31 15:28 ` Andre Muezerie
1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2025-01-31 10:43 UTC (permalink / raw)
To: Vladimir Medvedkin; +Cc: dev, anatoly.burakov, bruce.richardson, andremue
On Thu, Jan 30, 2025 at 8:26 PM Vladimir Medvedkin
<vladimir.medvedkin@intel.com> wrote:
>
> Fix a typo in avx512 rx function, where accidentally the _mm_load_si128
> argument was passed by value instead of a pointer.
>
> Fixes: 43fd3624fdfe ("drivers: replace GCC pragma with cast")
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Indeed, it looks like a typo.
Sad that the CI did not catch it.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/ice: fix segmentation fault Rx function
2025-01-31 10:43 ` David Marchand
@ 2025-01-31 11:21 ` Bruce Richardson
0 siblings, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2025-01-31 11:21 UTC (permalink / raw)
To: David Marchand; +Cc: Vladimir Medvedkin, dev, anatoly.burakov, andremue
On Fri, Jan 31, 2025 at 11:43:53AM +0100, David Marchand wrote:
> On Thu, Jan 30, 2025 at 8:26 PM Vladimir Medvedkin
> <vladimir.medvedkin@intel.com> wrote:
> >
> > Fix a typo in avx512 rx function, where accidentally the _mm_load_si128
> > argument was passed by value instead of a pointer.
> >
> > Fixes: 43fd3624fdfe ("drivers: replace GCC pragma with cast")
> >
> > Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
> Indeed, it looks like a typo.
> Sad that the CI did not catch it.
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net-intel
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/ice: fix segmentation fault Rx function
2025-01-30 19:26 [PATCH] net/ice: fix segmentation fault Rx function Vladimir Medvedkin
2025-01-31 10:43 ` David Marchand
@ 2025-01-31 15:28 ` Andre Muezerie
1 sibling, 0 replies; 4+ messages in thread
From: Andre Muezerie @ 2025-01-31 15:28 UTC (permalink / raw)
To: Vladimir Medvedkin; +Cc: dev, anatoly.burakov, bruce.richardson
On Thu, Jan 30, 2025 at 07:26:17PM +0000, Vladimir Medvedkin wrote:
> Fix a typo in avx512 rx function, where accidentally the _mm_load_si128
> argument was passed by value instead of a pointer.
>
> Fixes: 43fd3624fdfe ("drivers: replace GCC pragma with cast")
> Cc: andremue@linux.microsoft.com
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
> drivers/net/intel/ice/ice_rxtx_vec_avx512.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/intel/ice/ice_rxtx_vec_avx512.c b/drivers/net/intel/ice/ice_rxtx_vec_avx512.c
> index 681b31f61f..bd49be07c9 100644
> --- a/drivers/net/intel/ice/ice_rxtx_vec_avx512.c
> +++ b/drivers/net/intel/ice/ice_rxtx_vec_avx512.c
> @@ -474,7 +474,7 @@ _ice_recv_raw_pkts_vec_avx512(struct ice_rx_queue *rxq,
> (RTE_CAST_PTR(const __m128i *, &rxdp[7].wb.status_error1));
> rte_compiler_barrier();
> const __m128i raw_desc_bh6 = _mm_load_si128
> - (RTE_CAST_PTR(const __m128i *, rxdp[6].wb.status_error1));
> + (RTE_CAST_PTR(const __m128i *, &rxdp[6].wb.status_error1));
> rte_compiler_barrier();
> const __m128i raw_desc_bh5 = _mm_load_si128
> (RTE_CAST_PTR(const __m128i *, &rxdp[5].wb.status_error1));
> --
> 2.43.0
Thanks for catching and fixing this.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-31 15:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-30 19:26 [PATCH] net/ice: fix segmentation fault Rx function Vladimir Medvedkin
2025-01-31 10:43 ` David Marchand
2025-01-31 11:21 ` Bruce Richardson
2025-01-31 15:28 ` Andre Muezerie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).