From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B1D345BC0; Thu, 24 Oct 2024 10:36:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 886E24339A; Thu, 24 Oct 2024 10:36:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9F0EE43352 for ; Thu, 24 Oct 2024 10:36:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729758995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eY0ZjP62fZroZND6xVfIRlPhgJj+NdrT9ZYLVDCoZLM=; b=V/d3uOA/ojRXGKzPCtWgj+2h0oLqy71tPKh894QpKPxzIgTsok+oQC5CXKGMgxupyxLhyQ 7gOk5WPcQMFy/wetOIG5r55Z+XuhWYvpsyIXBcQuB7OXMkzYJBUIFxXJV5iDAdPxFZ2Bv7 +mcPnKQ+PcvDtDMhmcpdIJ6RXsap8+s= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-GiIeOJfiMluWGiDYVQwySg-1; Thu, 24 Oct 2024 04:36:33 -0400 X-MC-Unique: GiIeOJfiMluWGiDYVQwySg-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-539ea0fcd4bso498187e87.2 for ; Thu, 24 Oct 2024 01:36:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729758992; x=1730363792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eY0ZjP62fZroZND6xVfIRlPhgJj+NdrT9ZYLVDCoZLM=; b=CPdjHKo9gkkIGcjLVI5d/9q9agCwtpQ2C033qFgEi9MEe/pj9KeHFqQyS9unZAhoUQ Ua3/j6E0tNuoBAwLr36nwwOqjWD0h7VsKrflz5gY8w2RAp0iCXcUGIz4wVdXNXV6PG3p bvLTARjQfQsQyIjEocy9JYnHla+0ZTQceQKnTMr3L/CtSB4NoPXuw+xCJq0N94Khwflr p64fbRSr5BjBl04vlPE711PKsbZL9NyF7x+GBaWvHU131UTLC5r6Wn0BDpIvjboZOuZn vb5yozI1XPdSdfuGOVPLEAwB1EUCrerfWX7GKfk1jMm4MkdNU/jdVTh7ZyFU9JK2oGYZ K0gA== X-Gm-Message-State: AOJu0Yy1oHPuWT4Jqa9SAykUapi8IkjsGGy9BK1YNqHXVjb6LMB+jeFp XQkHBUaNu7HnbIzHaNeRWuudklc50MUTQYZ7EyfNL1ppyB+2Z3UDUHaPahFDCJz5Qq4eN1wdj42 Z8W/4ozWydKXA/E2hzkY60tiwHLWRKsUYQ8tfuQGiMZnHC0zfdoz+9QMj2XpPrChY9Q2fpzYTIh S6FrOXzKlP91Q2CIM= X-Received: by 2002:a05:6512:68a:b0:539:896e:46c9 with SMTP id 2adb3069b0e04-53b1a36c88dmr2951994e87.45.1729758991759; Thu, 24 Oct 2024 01:36:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHV9l8pksW+Yg5sx5Q8osMJgzDsxgx1mC+0QY9Ddimk9a9CuIGomoQAhvpN/Iz+SCdhHsL47MaGteRtuqJ8JmE= X-Received: by 2002:a05:6512:68a:b0:539:896e:46c9 with SMTP id 2adb3069b0e04-53b1a36c88dmr2951970e87.45.1729758991366; Thu, 24 Oct 2024 01:36:31 -0700 (PDT) MIME-Version: 1.0 References: <20241024075441.3723352-1-maxime.coquelin@redhat.com> <20241024075441.3723352-6-maxime.coquelin@redhat.com> In-Reply-To: <20241024075441.3723352-6-maxime.coquelin@redhat.com> From: David Marchand Date: Thu, 24 Oct 2024 10:36:20 +0200 Message-ID: Subject: Re: [PATCH v2 5/6] vhost: fix and refactor VDUSE reconnect log check To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 24, 2024 at 9:55=E2=80=AFAM Maxime Coquelin wrote: > - if (reconnect_log->nr_vrings !=3D total_queues) { > - VHOST_CONFIG_LOG(name, ERR, > - "Queues number mismatch between b= ackend (%u) and reconnection file (%u)", > - total_queues, reconnect_log->nr_v= rings); > - ret =3D -1; > + ret =3D vduse_reconnect_log_check(reconnect_log, name, fe= atures, total_queues); > + if (ret < 0) { > + VHOST_CONFIG_LOG(name, ERR, "Reconnection log fil= e check failed"); Idem. Patch 6 will remove it. > goto out_log_unmap; > } > } else if (errno =3D=3D ENOENT) { > -- > 2.46.2 > --=20 David Marchand