From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1C43438FF; Fri, 19 Jan 2024 15:00:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAD064029F; Fri, 19 Jan 2024 15:00:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D027F40279 for ; Fri, 19 Jan 2024 15:00:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705672813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/fXKlMW2bLZ8hruyovDgAsMK2lTLrhaxEgmK0P51V30=; b=jSTVD807KiUUBHwsqw8lq7SoNnTQYd1dD1GDGAp7m3yHa2gqjl49fYu2VkYlfQ3kQR9xv0 mZHfOuxW4eomVAHgwRwcup3coMcO0ioymVXrw1dYcJWVRSEG9UbxIRvLJdR4/wa3E6D27R w84JBIlYNcW8SxtUS3mALMaMQoeWqJM= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-bL6zj3NaP2GmHhpo6KaVAQ-1; Fri, 19 Jan 2024 09:00:12 -0500 X-MC-Unique: bL6zj3NaP2GmHhpo6KaVAQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2cdb0cc793bso5820781fa.3 for ; Fri, 19 Jan 2024 06:00:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705672810; x=1706277610; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/fXKlMW2bLZ8hruyovDgAsMK2lTLrhaxEgmK0P51V30=; b=NBSFZ4UBt0+6dux4xRxkGi8dugnhqc/9nN2D/YYHVYiIyXAX89gOdX2IRT7RNJUWvS o0eh0FFRp+xLMt3EpMtpwwbRqTZ3kBvF+92o7XieikpeE5Q/vMGDyvFRpceXX3RlyHYH rft7BdVT9VPEYW3ljCAZZSnWWLejKzJEDU6xF135wOq8qR7D9S6I974tL3iOPuPOVoce 5EI4+NrE0vMcn1R34/yCwy7U647jPpRktuDJPwVG0PymEhdbiHsjpImR81L4Ep9nf1kF RJX4/YlCjKzDFVBhLbsBE3wFRGFFSrr89B2T396RrXOYdbl/V5NHdb217Ovk7e1a/u6s EV5w== X-Gm-Message-State: AOJu0Yxgow85Prn4Tga+/kNn+SvQsy7N+iJ0LSRWjfwWVKLqSeE/krrt uaMp6C7Ncb9Kz3QzWK/1vluvzYRuyz/i8SEhD743f2YvvtutCOL9iYaV5OnI/7nqdjrCfdNX7xN Z7DLWXF+iLEOF2jkafTi5yEcdr1xRXFsaCASlKoWsoREapitFxRPuwvXiRma+n+re/WFI7Hry7E ykckRl1Vi0m8eyh863ZSNDSWg= X-Received: by 2002:a05:651c:c8b:b0:2cd:fa5f:d7bf with SMTP id bz11-20020a05651c0c8b00b002cdfa5fd7bfmr1508335ljb.107.1705672810645; Fri, 19 Jan 2024 06:00:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFMzf62WpeERbVz94A689sQ5P/a4R5kSm0uAKbURW0mVhXu+lFHXRCfOabj42yhwhwXZi8t1JgDa/0wKhbW8cs= X-Received: by 2002:a05:651c:c8b:b0:2cd:fa5f:d7bf with SMTP id bz11-20020a05651c0c8b00b002cdfa5fd7bfmr1508323ljb.107.1705672810203; Fri, 19 Jan 2024 06:00:10 -0800 (PST) MIME-Version: 1.0 References: <20231213014408.612051-1-stephen@networkplumber.org> <20231222171820.8778-1-stephen@networkplumber.org> In-Reply-To: <20231222171820.8778-1-stephen@networkplumber.org> From: David Marchand Date: Fri, 19 Jan 2024 14:59:58 +0100 Message-ID: Subject: Re: [PATCH v6 00/20] Remove uses of PMD logtype To: Stephen Hemminger Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Dec 22, 2023 at 6:18=E2=80=AFPM Stephen Hemminger wrote: > > The generic RTE_LOGTYPE_PMD is a leftover and should be removed. > This replaces all uses in current tree. It leaves PMD logtype > as deprecated because there maybe other uses in external projects > leftover. > > This version does not use Depends-on: because CI system can't > handle that and want to make sure no PMD left behind > > v6 - add a couple of more places > remove PMD logtype in last patch This series mixes unrelated changes, like adding missing \n or removing some of them. I identified a couple of places where it introduces issues by doing so. Please focus on changing the logtype / log macros and not silently "fix" other log issues. We can fix the latter, later. Details of what I spotted: - there is the "funny" case of event/dlb2 where the DLB2_LOG_DBG macro does not add a \n, while _INFO and _ERR do, - there is also the case of some _DP log macros in some drivers. For the drivers below, the _DP macro won't add a \n, while their non _DP macro equivalent do add one... $ git grep 'RTE_LOG_DP(.*fmt' drivers/ | grep -v '\\n' | cut -d : -f 1 | xargs grep -B1 -w RTE_LOG_DP drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h-#define rte_bbdev_dp_log(level, fmt, args...) \ drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/bus/cdx/cdx_logs.h-#define CDX_BUS_DP_LOG(level, fmt, args...) \ drivers/bus/cdx/cdx_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/bus/fslmc/fslmc_logs.h-#define DPAA2_BUS_DP_LOG(level, fmt, args...= ) \ drivers/bus/fslmc/fslmc_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/common/dpaax/dpaax_logs.h-#define DPAAX_DP_LOG(level, fmt, args...)= \ drivers/common/dpaax/dpaax_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h-#define DPAA2_SEC_DP_LOG(level, fmt, args...) \ drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/crypto/dpaa_sec/dpaa_sec_log.h-#define DPAA_SEC_DP_LOG(level, fmt, args...) \ drivers/crypto/dpaa_sec/dpaa_sec_log.h: RTE_LOG_DP(level, PMD, fmt, ## a= rgs) -- drivers/event/dlb2/dlb2_log.h-#define DLB2_LOG_DBG(fmt, args...) \ drivers/event/dlb2/dlb2_log.h: RTE_LOG_DP(DEBUG, PMD, fmt, ## args) -- drivers/event/dpaa2/dpaa2_eventdev_logs.h-#define DPAA2_EVENTDEV_DP_LOG(level, fmt, args...) \ drivers/event/dpaa2/dpaa2_eventdev_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/event/dsw/dsw_evdev.h-#define DSW_LOG_DP(level, fmt, args...) \ drivers/event/dsw/dsw_evdev.h: RTE_LOG_DP(level, EVENTDEV, "[%s] %s() line %u: " fmt, \ -- drivers/mempool/dpaa/dpaa_mempool.h-#define DPAA_MEMPOOL_DPDEBUG(fmt, args.= ..) \ drivers/mempool/dpaa/dpaa_mempool.h: RTE_LOG_DP(DEBUG, PMD, fmt, ## args= ) -- drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h-#define DPAA2_MEMPOOL_DP_LOG(level, fmt, args...) \ drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/net/dpaa/dpaa_ethdev.h-#define DPAA_DP_LOG(level, fmt, args...) \ drivers/net/dpaa/dpaa_ethdev.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/net/dpaa2/dpaa2_pmd_logs.h-#define DPAA2_PMD_DP_LOG(level, fmt, args...) \ drivers/net/dpaa2/dpaa2_pmd_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/net/enetc/enetc_logs.h-#define ENETC_PMD_DP_LOG(level, fmt, args...= ) \ drivers/net/enetc/enetc_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/net/enetfec/enet_pmd_logs.h-#define ENETFEC_DP_LOG(level, fmt, args...) \ drivers/net/enetfec/enet_pmd_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args= ) -- drivers/net/pfe/pfe_logs.h-#define PFE_DP_LOG(level, fmt, args...) \ drivers/net/pfe/pfe_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) --=20 David Marchand