From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/2] remove __typeof__ from expansion of per lcore macros
Date: Tue, 13 Feb 2024 12:12:37 +0100 [thread overview]
Message-ID: <CAJFAV8xdUN=9=_MBLOdKW+_c5BLkSpNX-J_HuUkLtEwn7Ep+DQ@mail.gmail.com> (raw)
In-Reply-To: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com>
On Tue, Dec 19, 2023 at 6:28 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> The design of the macros requires a type to be provided to the macro.
>
> By expanding the type parameter inside of typeof it also inadvertently
> allows an expression to be used which appears not to have been intended
> after evaluating the parameter name and existing macro use.
>
> Technically this is an API break but only for applications that were
> using these macros outside of the original design intent.
Please add a release note on this topic (I am fine with just a reply
to this mail, I can fold this change when applying).
The rest lgtm.
--
David Marchand
next prev parent reply other threads:[~2024-02-13 11:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 17:27 Tyler Retzlaff
2023-12-19 17:27 ` [PATCH 1/2] eal: provide type instead of expression to per lcore macro Tyler Retzlaff
2023-12-19 17:27 ` [PATCH 2/2] eal: remove typeof from per lcore macros Tyler Retzlaff
2023-12-19 17:36 ` [PATCH 0/2] remove __typeof__ from expansion of " Bruce Richardson
2024-01-02 23:44 ` [PATCH v2 0/3] " Tyler Retzlaff
2024-01-02 23:45 ` [PATCH v2 1/3] eal: provide type to per lcore macro Tyler Retzlaff
2024-01-02 23:45 ` [PATCH v2 2/3] crypto/ipsec_mb: " Tyler Retzlaff
2024-01-02 23:45 ` [PATCH v2 3/3] eal: remove typeof from per lcore macros Tyler Retzlaff
2024-01-08 10:45 ` [PATCH v2 0/3] remove __typeof__ from expansion of " Bruce Richardson
2024-02-13 11:12 ` David Marchand [this message]
2024-02-13 19:12 ` [PATCH v3 " Tyler Retzlaff
2024-02-13 19:12 ` [PATCH v3 1/3] eal: provide type to per lcore macro Tyler Retzlaff
2024-02-13 19:12 ` [PATCH v3 2/3] crypto/ipsec_mb: " Tyler Retzlaff
2024-02-13 19:12 ` [PATCH v3 3/3] eal: remove typeof from per lcore macros Tyler Retzlaff
2024-02-13 19:32 ` Morten Brørup
2024-02-14 8:19 ` [PATCH v3 0/3] remove __typeof__ from expansion of " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xdUN=9=_MBLOdKW+_c5BLkSpNX-J_HuUkLtEwn7Ep+DQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).