From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5663E41EB0; Thu, 16 Mar 2023 13:51:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3592340DF6; Thu, 16 Mar 2023 13:51:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 166D840A89 for ; Thu, 16 Mar 2023 13:51:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678971115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oOa9KRaTdGLrlZ3lGsMeSWeF1AOjcOVSeo1YO3sp05A=; b=ftnHqYZMhfRSyErikWnzXMdzq+tA1fYIjoZmA1+8ADu6pewrstb1q2byJS5XmLMvRzd+T9 Li/Pt+trtmCAD2Oth/IFjxoYHLqcpEt5TeFihpq+U6eMumbevOsdIuGEiNxW6lIdFEo6yZ FgMQULTblVDY1mkJTrgHn3/LpxX+tkU= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-50-7zX43QL4N32aqWI4uHXkHA-1; Thu, 16 Mar 2023 08:51:54 -0400 X-MC-Unique: 7zX43QL4N32aqWI4uHXkHA-1 Received: by mail-pl1-f199.google.com with SMTP id k17-20020a170902d59100b0019abcf45d75so928072plh.8 for ; Thu, 16 Mar 2023 05:51:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678971113; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oOa9KRaTdGLrlZ3lGsMeSWeF1AOjcOVSeo1YO3sp05A=; b=HXTt3vqjjlGs1aseVCTt6yhkvjqVJoxXCnZpKjKiEBTNXmPMv/UeTF1OxBvyRcJSpv n/KcZcw87Jws5y6lOTkM+eCvubVIDuKFTSn7XaZ8ausJnHeSL4/z3HPJzV2KXKtB++DA bNo63o7PsjoFAhtJUxxdmUi0/ekq9oLKgPVKpAmfvYPDfscgc7zeZUAWVUEDRjV1bYHi uD7AK+AqsHpPXGccEPhQDxG6XT+6Ps02FpRHAU0EGwO2EDoUaM522clm3HYjw19J4/bD faujKBX3n1CN0YFMsulxOL4/4qhAOrl/o/I7/4rqOFrTeIuYkTpC3FUP1gtzpAhnBE8M t/9w== X-Gm-Message-State: AO0yUKWsuKpwr97ICBnIF9jwS4i1LwFcevk1/dQIiUb7evuVgJ6F+K4K S2nh9OuMId/v0tBPck0wiwomxkwwoUOquoKVY9AALvAhMD2JUtvOgyJtYfIriazE/uvzPa8Lvlq ucZ0nKCcITSBtOVJzP6M4wt55UqE= X-Received: by 2002:a62:d408:0:b0:624:3ff:db10 with SMTP id a8-20020a62d408000000b0062403ffdb10mr1219868pfh.5.1678971113442; Thu, 16 Mar 2023 05:51:53 -0700 (PDT) X-Google-Smtp-Source: AK7set+Wn4gS1hjS+DO+rdlRd9jXpX5ylanBMQVNF0glgnJ6KfSJ/ZrrCNFffIxJ1BcpRjq1MBoeNn/TeQL1CsprXA4= X-Received: by 2002:a62:d408:0:b0:624:3ff:db10 with SMTP id a8-20020a62d408000000b0062403ffdb10mr1219855pfh.5.1678971113021; Thu, 16 Mar 2023 05:51:53 -0700 (PDT) MIME-Version: 1.0 References: <20230310142604.2409586-1-david.marchand@redhat.com> In-Reply-To: <20230310142604.2409586-1-david.marchand@redhat.com> From: David Marchand Date: Thu, 16 Mar 2023 13:51:42 +0100 Message-ID: Subject: Re: [PATCH 1/2] raw/skeleton: fix selftest To: dev@dpdk.org Cc: stable@dpdk.org, Sachin Saxena , Hemant Agrawal , Yu Jiang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 10, 2023 at 3:26=E2=80=AFPM David Marchand wrote: > > ASan reported issues in this driver. > > rte_rawdev_obj_t context object points at a uint16_t. > skeleton_rawdev_enqueue_bufs() and skeleton_rawdev_dequeue_bufs() were > incorrectly casting to an int. > > The enqueue/dequeue selftest had a leak on the enqueued string and was > wrong in passing a rte_rawdev_buf pointer array. > Fix this by allocating buffers on the stack and check that returned > string is the expected one. > Bugzilla ID: 999 > Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver") > Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Series applied. --=20 David Marchand