From: David Marchand <david.marchand@redhat.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>,
Sivaprasad Tummala <Sivaprasad.Tummala@intel.com>
Cc: Marko Kovacevic <marko.kovacevic@intel.com>,
Ori Kam <orika@mellanox.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>,
Sunil Kumar Kori <skori@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>, dev <dev@dpdk.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v1] examples/l2fwd: add check for promiscuous no support
Date: Fri, 24 Apr 2020 22:33:18 +0200 [thread overview]
Message-ID: <CAJFAV8xdqsFcEAqEUXmegzggWm6u5nnq7D6YKE=NiAx2JXkjQw@mail.gmail.com> (raw)
In-Reply-To: <20200226134355.GC105977@intel.com>
On Wed, Feb 26, 2020 at 2:46 PM Ye Xiaolong <xiaolong.ye@intel.com> wrote:
> On 02/26, David Marchand wrote:
> >On Wed, Feb 26, 2020 at 10:15 AM Sivaprasad Tummala
> ><Sivaprasad.Tummala@intel.com> wrote:
> >>
> >> l2fwd application exits, if return for rte_eth_promiscuous_enable
> >> is not success. But for vHost PMD, promiscuous enable returns "Not
> >> Supported".
> >
> >Could the vhost pmd announce that it is already in promiscuous mode?
> >Like in f165210321c4 ("drivers/net: enable promiscuous and multicast
> >by default")
>
> I think it makes sense, I don't see any risk of doing it. I'll cook a patch
> for it soon.
Now that vhost has been fixed [1], I'll mark this patch as rejected.
1: https://git.dpdk.org/dpdk/commit?id=a2154606ffa6b5ddacbebd8714facc7e2fda3262
Thanks.
--
David Marchand
next prev parent reply other threads:[~2020-04-24 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 9:15 Sivaprasad Tummala
2020-02-26 9:22 ` David Marchand
2020-02-26 13:43 ` Ye Xiaolong
2020-04-24 20:33 ` David Marchand [this message]
2020-02-26 13:45 ` [dpdk-dev] [PATCH] net/vhost: enable promiscuous and multicast by default Xiaolong Ye
2020-03-04 8:03 ` Maxime Coquelin
2020-04-10 14:44 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xdqsFcEAqEUXmegzggWm6u5nnq7D6YKE=NiAx2JXkjQw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=Sivaprasad.Tummala@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=orika@mellanox.com \
--cc=pbhagavatula@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=skori@marvell.com \
--cc=tomasz.kantecki@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).