From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25626A00C2; Fri, 24 Apr 2020 22:33:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B8DC1C222; Fri, 24 Apr 2020 22:33:35 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id A66451C1CE for ; Fri, 24 Apr 2020 22:33:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587760414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0oCtAr+0AfQWq0aZbmywOEtyMnFR4Mft+Int2Pn1mDc=; b=DxDSw9GalmjD0svHIeRG8tgisjkXQppTLoN0/GTfeOhf8XiPVfRbHC0E8utefO/r6vDJji 4WGBDT3Yk0cAaprda0rCdjvPp5qvvwDEITvP/pGKQbBjUe/dJt1nnjAeb3J/tzCHm0ZWbp 7bNrLlA/YRygMGj9IdJX+yIP3c7dQL8= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-437-YocA7kNTPHWS6fmB6AFPpw-1; Fri, 24 Apr 2020 16:33:30 -0400 X-MC-Unique: YocA7kNTPHWS6fmB6AFPpw-1 Received: by mail-ua1-f70.google.com with SMTP id m26so5964301uao.2 for ; Fri, 24 Apr 2020 13:33:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P0hmXxLEP0mPz/Tx0QCDY4PSqru+JHa18Dh3brUsHNY=; b=H0/PMfXYmKI7qlhKd1AI5ps57THNlr9MmzM6PDtgZ9bT9//3iyqKnepnnv1b4BcxOk /PNJbWFp28NJ0IHj6VVK9fOlJ7GtGHAT+T2fiI47p7DcQx0mQ8Vi55rMaX4JjsqbF6ZS qRKzSmWPEg8N1fJBMvopWG6t0Zy57yKEHHg/+dnGwAfebsCMf1yVonK8jeyWnx/+jHeG Rxn6gf6Thk/l6z3ulYZpsX/EoGGW99PngfzrRiZ43L5J3Hrlh7Y9zF/N9L2FZPw9nvOv J5XTSBRkyRquWY/FYvQM3ybJEyx97qlMuEbZRke3xgS+worUTAW07U3io6RcmYWkB/1V bjhQ== X-Gm-Message-State: AGi0Pubx38zuCICTd1afApSBi0d60cZHpuN5XnCge8qjjwe6KWVPtyIR lUr+MZn75rZerWewLxj/nr3ZuwVMwJAElraVJ3ttHIkRv1Y70Wl0XmU6CIUApz6z/jyDqd2Liw2 lvo25hdEp0wvKO3P1KIQ= X-Received: by 2002:a1f:9ac7:: with SMTP id c190mr9830374vke.39.1587760409840; Fri, 24 Apr 2020 13:33:29 -0700 (PDT) X-Google-Smtp-Source: APiQypLP42t6Rq2BUHlrFwk+Ggg5kqRLH+y1tXPJ2hAGspRvSlc7KobY+VpPJA38NJgZxH6PpS9Ow4rRDPbaY+jlZ24= X-Received: by 2002:a1f:9ac7:: with SMTP id c190mr9830353vke.39.1587760409574; Fri, 24 Apr 2020 13:33:29 -0700 (PDT) MIME-Version: 1.0 References: <20200226091501.27967-1-Sivaprasad.Tummala@intel.com> <20200226134355.GC105977@intel.com> In-Reply-To: <20200226134355.GC105977@intel.com> From: David Marchand Date: Fri, 24 Apr 2020 22:33:18 +0200 Message-ID: To: Ye Xiaolong , Sivaprasad Tummala Cc: Marko Kovacevic , Ori Kam , Bruce Richardson , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Pavan Nikhilesh , dev , Maxime Coquelin X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1] examples/l2fwd: add check for promiscuous no support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 26, 2020 at 2:46 PM Ye Xiaolong wrote: > On 02/26, David Marchand wrote: > >On Wed, Feb 26, 2020 at 10:15 AM Sivaprasad Tummala > > wrote: > >> > >> l2fwd application exits, if return for rte_eth_promiscuous_enable > >> is not success. But for vHost PMD, promiscuous enable returns "Not > >> Supported". > > > >Could the vhost pmd announce that it is already in promiscuous mode? > >Like in f165210321c4 ("drivers/net: enable promiscuous and multicast > >by default") > > I think it makes sense, I don't see any risk of doing it. I'll cook a pat= ch > for it soon. Now that vhost has been fixed [1], I'll mark this patch as rejected. 1: https://git.dpdk.org/dpdk/commit?id=3Da2154606ffa6b5ddacbebd8714facc7e2f= da3262 Thanks. --=20 David Marchand