From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D83AA00C4; Mon, 11 Apr 2022 09:32:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29E7940685; Mon, 11 Apr 2022 09:32:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AC43B4067B for ; Mon, 11 Apr 2022 09:32:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649662353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2zGzOdF/SX9H0fBNqCCOz0sW8kOY7g6AgHVpnSLgk5Y=; b=iBu/405nP0c3Y+7v6Zmlv2hUYPFXdiXbziA6o2+vzabDOiXd/+LjWcpscvzFSso1t1+CCo hT6yAzIrNVB3YNO8aSL5PfuCgAVEzc/eBL0DOvDtpaD4JOBXoH+Ru6mavX6G0NXLGlMsxJ a+rRMWkrgkFVAp6WUzM4sfuX5lFNElU= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-137-_3UE_Pj6MySPlfd4Szbxmw-1; Mon, 11 Apr 2022 03:32:32 -0400 X-MC-Unique: _3UE_Pj6MySPlfd4Szbxmw-1 Received: by mail-lj1-f197.google.com with SMTP id d22-20020a2e9296000000b0024b5eee4311so1299240ljh.4 for ; Mon, 11 Apr 2022 00:32:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2zGzOdF/SX9H0fBNqCCOz0sW8kOY7g6AgHVpnSLgk5Y=; b=Ibu/rTax1hTu7z6/YlW23qaCJsnyAgo6rQycd/uBrwlbpIH0kyqIO/g550W3d2IZcE l/uk49rpBobrF9eaDa2O4/6r/0h+jY3kp/4xMw2Efuc6raqIgpzMw3LtFtkK/BbUtn7U DQbfTRBWn0Ci6AJVBMixbFTiBk+XWQ4Xflf5RlCsLN9+1Guful6HOlgOl1KssXgZOb6L wN9/zUWT9z6PpBnmTHN6Didhn9TlWGEYlZAGcHDC7bhIVBlktmmI8kifFLj0qyNZMnb6 IWgo64ZhwEhlslfyALzBWujOJF0DuM4uqQG47xExVy85BEM96xJR9TJHl0/OKNd+p0TW 49iQ== X-Gm-Message-State: AOAM533Z/uBxZvMBWtb/bK8TVfrrkdd2KoE9lbtefNmCIwyep0C9S2Zf bMM2Y4/TFSUemrNSrk/FL+si9xyingnN5wFZ/atKA92oDiqoYzd4Dij5LBj4WCLtAx2niZeHaOp nwD3g3CaHw/gMTlxeV34= X-Received: by 2002:a05:6512:3f1b:b0:450:abeb:33cf with SMTP id y27-20020a0565123f1b00b00450abeb33cfmr20370351lfa.217.1649662350499; Mon, 11 Apr 2022 00:32:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3li0VZuQoK7Vr76NT52FA99wYmlu3Dl+5J/GYGJ9j9C7TRjR8AkGrDz52ZcBCihzivDpkGTE9w1+LueVYtYA= X-Received: by 2002:a05:6512:3f1b:b0:450:abeb:33cf with SMTP id y27-20020a0565123f1b00b00450abeb33cfmr20370336lfa.217.1649662350262; Mon, 11 Apr 2022 00:32:30 -0700 (PDT) MIME-Version: 1.0 References: <1648819793-18948-1-git-send-email-roretzla@linux.microsoft.com> <20220408134614.GB550@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20220408134614.GB550@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Mon, 11 Apr 2022 09:32:19 +0200 Message-ID: Subject: Re: [PATCH 0/3] add eal functions for thread affinity To: Tyler Retzlaff Cc: dev , Thomas Monjalon , Dmitry Kozlyuk , "Burakov, Anatoly" , Narcisa Ana Maria Vasile Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 8, 2022 at 3:46 PM Tyler Retzlaff wrote: > > On Fri, Apr 08, 2022 at 10:57:55AM +0200, David Marchand wrote: > > Hello Tyler, > > > > On Fri, Apr 1, 2022 at 3:30 PM Tyler Retzlaff > > wrote: > > > > > > this series provides basic dependencies for additional eal thread api > > > additions. series includes basic error handling, initial get/set thread > > > affinity functions and minimal unit test. > > > > > > Tyler Retzlaff (3): > > > eal/windows: translate Windows errors to errno-style errors > > > eal: implement functions for get/set thread affinity > > > test/threads: add unit test for thread API > > > > > > app/test/meson.build | 2 + > > > app/test/test_threads.c | 86 +++++++++++++++++++ > > > lib/eal/include/rte_thread.h | 45 ++++++++++ > > > lib/eal/unix/rte_thread.c | 16 ++++ > > > lib/eal/version.map | 4 + > > > lib/eal/windows/eal_lcore.c | 173 +++++++++++++++++++++++++++---------- > > > lib/eal/windows/eal_windows.h | 10 +++ > > > lib/eal/windows/include/rte_os.h | 2 + > > > lib/eal/windows/rte_thread.c | 179 ++++++++++++++++++++++++++++++++++++++- > > > 9 files changed, 472 insertions(+), 45 deletions(-) > > > create mode 100644 app/test/test_threads.c > > > > We have two concurrent series, can you clarify what are the intentions > > on this work? > > yes, i should have clarified this up front sorry. > > > Is this series superseding Narcisa series? > > this series supersedes the series from Narcisa. it was resolved through > discussion that the current series should be abandoned as it is too > large and not making progress. > > we've elected to submit a series of smaller patchsets that incorporate > the feedback received to date and build up the api surface for > threading. the patches are still the work of Narcisa but she is > overscheduled so i will assist in upstreaming and addressing feedback. > > additionally, rather than port the tree to the new __experimental api as > they are added we will prefer to add unit tests that provide validation > of the api and example usage. > > our hope is the smaller scoped series will attract more attention and > have better acknowledgement velocity. > > i will have Narcisa mark the monolithic series as superseded on > patchwork. Ok, thanks Tyler. -- David Marchand