From: David Marchand <david.marchand@redhat.com>
To: Gregory Etelson <getelson@nvidia.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
Luca Boccassi <bluca@debian.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>,
Kevin Traynor <ktraynor@redhat.com>,
Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v4] build: add pkg-config validation
Date: Fri, 13 Nov 2020 16:32:54 +0100 [thread overview]
Message-ID: <CAJFAV8xeOScJQDPh9H7iPG7H104CiXLjEEPaX+wNFiRh0A9rog@mail.gmail.com> (raw)
In-Reply-To: <MN2PR12MB463932822FDE02554420620EA5E60@MN2PR12MB4639.namprd12.prod.outlook.com>
On Fri, Nov 13, 2020 at 4:16 PM Gregory Etelson <getelson@nvidia.com> wrote:
> The patch notifies about invalid pkg-config. Application that uses such
> pkg-config will receive wrong linker parameters. These parameters will not
> fail link procedure, but may produce invalid output and as the result,
> application will have unpredicted behavior.
> Optimal notification would be during application build procedure, but
> I cannot see how it's possible to interact with an external build.
Me neither, so I don't see the point in adding a warning the final
user won't catch.
Documenting this known issue seems enough.
--
David Marchand
next prev parent reply other threads:[~2020-11-13 15:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 9:16 [dpdk-dev] [PATCH] " Gregory Etelson
2020-11-01 10:01 ` Thomas Monjalon
2020-11-01 12:06 ` Gregory Etelson
2020-11-02 6:45 ` [dpdk-dev] [PATCH v2] " Gregory Etelson
2020-11-02 12:11 ` Bruce Richardson
2020-11-02 19:39 ` Gregory Etelson
2020-11-02 19:34 ` [dpdk-dev] [PATCH v3] " Gregory Etelson
2020-11-03 10:09 ` Bruce Richardson
2020-11-04 8:38 ` Gregory Etelson
2020-11-05 12:37 ` [dpdk-dev] [PATCH v4] " Gregory Etelson
2020-11-05 13:17 ` Bruce Richardson
2020-11-13 13:38 ` David Marchand
2020-11-13 15:16 ` Gregory Etelson
2020-11-13 15:32 ` David Marchand [this message]
2020-11-17 18:17 ` [dpdk-dev] [PATCH] doc: notify bug in pkg-config v0.27 Gregory Etelson
2020-11-26 15:42 ` [dpdk-dev] [PATCH v2 1/1] doc: add pkg-config requirement for applications Thomas Monjalon
2020-11-26 16:24 ` Bruce Richardson
2020-11-26 16:38 ` Thomas Monjalon
2020-11-26 16:43 ` [dpdk-dev] [PATCH v3 " Thomas Monjalon
2020-11-26 16:46 ` Bruce Richardson
2020-11-27 0:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xeOScJQDPh9H7iPG7H104CiXLjEEPaX+wNFiRh0A9rog@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=ktraynor@redhat.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).