From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D68FA0093; Mon, 18 May 2020 18:30:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F91A1D454; Mon, 18 May 2020 18:30:50 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 259021D17A for ; Mon, 18 May 2020 18:30:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589819447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pIg/YGFRGp1VA4OxqJKD6TPZEn2QAUarC7gGK1GtdAY=; b=AHbwOB9qtUIgUMsnVLBnIUra+PLBm0t2FV2yljWb453+Io7Mf9OezTxUiVSQvbdPpW9XWs N3pfhiWogg0PO1Tz0M6lUETn+TKfFV2VNYeyMyXpNc5uUq2bkLtpSn7KXg6bJbHVz+4ofI mmu4jisCPptLbISYffQpB/DHeDQxMq0= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-218-D9JGZPfxO-W33qtHLYPqvA-1; Mon, 18 May 2020 12:30:43 -0400 X-MC-Unique: D9JGZPfxO-W33qtHLYPqvA-1 Received: by mail-il1-f200.google.com with SMTP id m9so3419796ili.3 for ; Mon, 18 May 2020 09:30:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pIg/YGFRGp1VA4OxqJKD6TPZEn2QAUarC7gGK1GtdAY=; b=ny04PzFdTMNV9GnolvulNRvpuJ9MHuSNky7ZqPbnevEk4qDA0m0/LX97j4dFH0eq1N bTDCo5aRrkuwxa/Hd+HoAKagApZwoDnRAkIAtJGDp7Yj2Ojb7l0kv0bBzpeyq7oFg1FV DCD1rZiZFjblb9XODlEMt2EhxgjCZyzVL5H/ti6CTH2dX4+RDXkvSZxJtwlxUZ9tMHXB URNl4fafvwO/dCqg0UF7goih8YUikP9IahSKXqosF8EgFTLVRRfg2MnvfOTGm6BiS/VZ JOCioM4g+5iVJBQaiKMrdJilC5A66z7Aa/Ok3Hd8BhNABAbz2tggy+gSQsqvqpVup8a4 ECyg== X-Gm-Message-State: AOAM532eJdyZAS2Gh3h8DiTi10Xn95BdsZxuDM3KaE1ruN9N/MBISGyl hEQ1r1Cc26qwDVr/2iGB6uIs0HEi6aJ/SxDDz1ZZldBV7KCPNBvK34So3bL3IRMNZXNcHqGUL0n HiltPBOkUIDthVIUl/gM= X-Received: by 2002:a92:aa07:: with SMTP id j7mr11222023ili.40.1589819442392; Mon, 18 May 2020 09:30:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxa3tm6md5JKwe42ontQdiglIfqpTQ/ZmDWlUICKZcC4gr9mTokOnTGc/I2GD/ENp7K6N0ZTh8laBK32jahGN8= X-Received: by 2002:a92:aa07:: with SMTP id j7mr11222000ili.40.1589819442123; Mon, 18 May 2020 09:30:42 -0700 (PDT) MIME-Version: 1.0 References: <20200508232505.2275-1-stephen@networkplumber.org> <20200511090438.GB1957@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200511090438.GB1957@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Mon, 18 May 2020 18:30:31 +0200 Message-ID: To: Stephen Hemminger Cc: "Burakov, Anatoly" , dev , pbhagavatula@caviumnetworks.com, Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal: remove register from function parameter in headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 11, 2020 at 11:05 AM Bruce Richardson wrote: > > On Mon, May 11, 2020 at 09:56:10AM +0100, Burakov, Anatoly wrote: > > On 09-May-20 12:25 AM, Stephen Hemminger wrote: > > > Compiling a C++ application that includes directly or indirectly > > > rte_common.h will cause a warning: > > > > > > include/rte_common.h:350:37: warning: ISO C++17 does not allow =E2=80= =98register=E2=80=99 storage class specifier [-Wregister] > > > rte_combine32ms1b(register uint32_t x) > > > > > > C++ pickier than standard C and flags this antique usage. > > > > > > This is a bugfix please apply to 20.05. > > > The register keyword is an old K&R legacy and should be removed > > > everywhere in DPDK. For now, fix it where it hurts. > > > Checkpatch should also be able to flag use of register keyword. > > > > > > Fixes: 08f683174e94 ("eal: add functions for previous power of 2 alig= nment") Cc: stable@dpdk.org > > > Signed-off-by: Stephen Hemminger > Acked-by: Bruce Richardson Applied, thanks. --=20 David Marchand