Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue

[David Marchand <david.marchand@redhat.com>]

This patch has been sent with a date in the future.
Date: Mon, 17 Feb 2020 16:43:45 +0000

Please fix your mail setup, this triggers an error with meson in UNH
CI (at least).


-- 
David Marchand

On Mon, Feb 17, 2020 at 9:09 AM <taox.zhu@intel.com> wrote:
>
> From: Tao Zhu <taox.zhu@intel.com>
>
> Change the definition of C99 style to C90 style.
> compile log as below:
>
> otx2_mempool_ops.c: In function ‘otx2_npa_populate’:
> /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \
>         ‘for’ loop initial declarations are only allowed in C99 mode
>   for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
>   ^
> /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: \
>         note: use option -std=c99 or -std=gnu99 to compile your code
> /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c: At top level:
> cc1: error: unrecognized command line option \
>         "-Wno-address-of-packed-member" [-Werror]
> cc1: all warnings being treated as errors
> make[6]: *** [otx2_mempool_ops.o] Error 1
> make[5]: *** [octeontx2] Error 2
> make[4]: *** [mempool] Error 2
>
> Fixes: 9ed8e95c ("mempool/octeontx2: optimize for L1D cache architecture")
>
> Signed-off-by: Tao Zhu <taox.zhu@intel.com>
> ---
>  drivers/mempool/octeontx2/otx2_mempool_ops.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c
> index 6b55447..ac2d618 100644
> --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c
> +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c
> @@ -754,6 +754,7 @@
>         size_t total_elt_sz;
>         uint8_t set;
>         size_t off;
> +       int i;
>
>         if (iova == RTE_BAD_IOVA)
>                 return -EINVAL;
> @@ -787,7 +788,7 @@
>         otx2_npa_dbg("requested objects %"PRIu64", possible objects %"PRIu64"",
>                      (uint64_t)max_objs, (uint64_t)(len / total_elt_sz));
>         otx2_npa_dbg("L1D set distribution :");
> -       for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
> +       for (i = 0; i < OTX2_L1D_NB_SETS; i++)
>                 otx2_npa_dbg("set[%d] : objects : %"PRIu64"", i,
>                              distribution[i]);
>
> --
> 1.8.3.1
>