From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D265A0487 for ; Mon, 29 Jul 2019 12:36:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6286F1BF1A; Mon, 29 Jul 2019 12:36:36 +0200 (CEST) Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 9E0BA1BEE1 for ; Mon, 29 Jul 2019 12:36:35 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id j21so23776688uap.2 for ; Mon, 29 Jul 2019 03:36:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FPMawlZy7IJI5o/3os/PW1lXpfQgKWU2mwFzizWgKcI=; b=Y/h87OTg4Ti5RCD2SICAeOunoeDJLnh9CwW1oB9/lavM9n7UKoNvnuzxxg0/bS1Zfb mqsZZD9lUCsgVZQeaigcvD+peg4UraAb5sVLWjBbKVV+QdNtPwoV1eQ2wfPj8DyOUUEx TYUMvesn+5kW9m8/5ZepMgTzIkGy2v7jWRXIdir61gS0Jwx3RB1veZPhOn240zH29noP mLS5eN6zRauYg80Asz+dgU9ThwsIcjOAR6OWKtPdvOhoFLTnH6Zy+LhycRK8pO8UNFbE TKMJrXhdv1TdscpfmUkl7Wq1LhSwSUM25lqs4WYeN3kj6mCk3kQoD/szjai6Ri1XhDBZ 0vIA== X-Gm-Message-State: APjAAAVS37cAKsou183KgPS6WR1tRnWzfcwXHcqJuBT2JXl0m7jY7SnH Rhzjwn32l/9l4iJzjLr0M1mTCVmZ3fJ844AajgGAG3w2 X-Google-Smtp-Source: APXvYqyGCGRLh7zQG7qicDOQYmtRuC61akW76u9hD6xeTV8GN4VENT0Mq2PHUJJCqMVsUTF+XUSZdCWC9dXSaAG5Bvc= X-Received: by 2002:ab0:168a:: with SMTP id e10mr20578961uaf.87.1564396594886; Mon, 29 Jul 2019 03:36:34 -0700 (PDT) MIME-Version: 1.0 References: <20190717112031.10968-1-thomas@monjalon.net> <20190717155202.1674-1-thomas@monjalon.net> <20190717155202.1674-2-thomas@monjalon.net> In-Reply-To: <20190717155202.1674-2-thomas@monjalon.net> From: David Marchand Date: Mon, 29 Jul 2019 12:36:22 +0200 Message-ID: To: Thomas Monjalon Cc: dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/2] devtools: allow misc options in null test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 17, 2019 at 5:53 PM Thomas Monjalon wrote: > > In order to ease basic testing with customized options, > EAL and testpmd options can be added as third and fourth arguments > of the "null PMD" script. > > Also, the first argument becomes more flexible by accepting > the testpmd path as an alternative to the build directory. > > Signed-off-by: Thomas Monjalon > --- > devtools/test-null.sh | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/devtools/test-null.sh b/devtools/test-null.sh > index 6928a6c15..69eddc359 100755 > --- a/devtools/test-null.sh > +++ b/devtools/test-null.sh > @@ -5,10 +5,13 @@ > > # Run a quick testpmd forwarding with null PMD without hugepage > > -build=${1:-build} > +build=${1:-build} # first argument can be the build directory > +testpmd=$1 # or first argument can be the testpmd path > coremask=${2:-3} # default using cores 0 and 1 > +eal_options=$3 > +testpmd_options=$4 > > -testpmd=$build/app/dpdk-testpmd > +[ -f "$testpmd" ] || testpmd=$build/app/dpdk-testpmd > [ -f "$testpmd" ] || testpmd=$build/app/testpmd > if [ ! -f "$testpmd" ] ; then > echo 'ERROR: testpmd cannot be found' >&2 > @@ -22,5 +25,5 @@ fi > > (sleep 1 && echo stop) | > $testpmd -c $coremask --no-huge -m 150 \ > - $libs --vdev net_null1 --vdev net_null2 -- \ > - --no-mlockall --total-num-mbufs=2048 -ia > + $libs --vdev net_null1 --vdev net_null2 $eal_options -- \ > + --no-mlockall --total-num-mbufs=2048 $testpmd_options -ia > -- > 2.21.0 > Not sure I would have split this from the first patch. Out of curiosity, what are the cases where you need to set options? -- David Marchand