From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 544CFA0C41; Wed, 17 Nov 2021 11:02:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EDDD41147; Wed, 17 Nov 2021 11:02:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5153E4068C for ; Wed, 17 Nov 2021 11:02:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637143340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gNsCSjmCkoSYO4GIT0Sp25/JDbWMxE2tzw5Rueq5770=; b=Tr1RVB+VCszFaNeE6S2eqXOnGwqUsAcyaeVwyfeEi+ejqh1vmmcJCMAiJs5n7isf/5vH6X FLBOw6qx33+WuGPlBn0lhgKjw6VrYOYg8O3igzDhVOn+/Q6PvJosMNa8HfAG5JJxVsQOg9 T4FcGYUnrFbYh27hhwKhRF5KnMy+pss= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-202-JiJLopwDNNWySGzGB_XdDA-1; Wed, 17 Nov 2021 05:02:15 -0500 X-MC-Unique: JiJLopwDNNWySGzGB_XdDA-1 Received: by mail-lf1-f72.google.com with SMTP id f15-20020a056512228f00b004037c0ab223so1112853lfu.16 for ; Wed, 17 Nov 2021 02:02:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gNsCSjmCkoSYO4GIT0Sp25/JDbWMxE2tzw5Rueq5770=; b=m3gfIxTz4hHp0yv8eVw89prfyZVbkPJ9bbD4NkHhhtmpg4xobxW3xKDZdtApSbqEDx LcjGHaBjSrCS3mE9Zu+NuFZlUbscFNqx60DbUjaiVJyj6SbKHqcfsOU4yEUZAVfLHcYq KGbXp+2hMwpGcuJ/SJq6iCGLD3AjLKsWTD2JeA3g36SeRI2muqIvQ3W99dGl6WIKZ0du aaAOFxRJy/qJSt/vGsoYODPmJPPJXXJWZd45NrfDRwmxCjD6MbhHwV3brqtmin38ZUb4 P5gcPMUQvPOpfyAqRK3TzUISKk9/bM8AiLvivze+WOp+LYMKbeKCiFuE8ZkqqiGDE/r4 /iRw== X-Gm-Message-State: AOAM532cwhJWdeqfrRrfnh0bJ/AV40sd/z/qRo4nuAYwzBZJg7PruRTl PRYQQzSCunSjBTSn27R5nHLcaGT1ri/qAeZPya3xcCcK2WerjEwz7HhlUYQwmR9CD1dZMvAQqlb +ilXqeNbC2VnNZxfgolM= X-Received: by 2002:a05:6512:aca:: with SMTP id n10mr14037171lfu.265.1637143333500; Wed, 17 Nov 2021 02:02:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJxCe5aVXDm9a+yZZprq0p2e02N/p6R4ZRl4iXHrVpxkbXYMd1iXYF90wlHdMVaselBLZTX4RhPsN296JCm9Rw8= X-Received: by 2002:a05:6512:aca:: with SMTP id n10mr14037128lfu.265.1637143333132; Wed, 17 Nov 2021 02:02:13 -0800 (PST) MIME-Version: 1.0 References: <20211116094205.750359-1-joyce.kong@arm.com> <20211117082200.1029621-1-joyce.kong@arm.com> In-Reply-To: <20211117082200.1029621-1-joyce.kong@arm.com> From: David Marchand Date: Wed, 17 Nov 2021 11:02:02 +0100 Message-ID: Subject: Re: [PATCH v3 00/12] use compiler atomic builtins for app modules To: Joyce Kong Cc: dev , Honnappa Nagarahalli , nd Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 17, 2021 at 9:22 AM Joyce Kong wrote: > > Since atomic operations have been adopted in DPDK now[1], > change rte_atomicNN_xxx APIs to compiler atomic built-ins > in app modules[2]. > > [1] https://www.dpdk.org/blog/2021/03/26/dpdk-adopts-the-c11-memory-model/ > [2] https://doc.dpdk.org/guides/rel_notes/deprecation.html > > v3: > 1. In pmd_perf test case, move the initialization of polling > start before calling rte_eal_remote_launch, so the update > is visible to the worker threads.(Honnappa Nagarahalli) > 2. Remove the rest rte_atomic.h which miss in v2.(David Marchand) > > v2: > By Honnappa Nagarahalli: > 1. Replace the RELAXED barriers with suitable ones for shared > data sync in pmd_perf and timer test cases. > 2. Avoid unnecessary atomic operations in compress and testpmd > modules. > 3. Fix some typo. > > Joyce Kong (12): > test/pmd_perf: use compiler atomic builtins for polling sync > test/ring_perf: use compiler atomic builtins for lcores sync > test/timer: use compiler atomic builtins for sync > test/stack_perf: use compiler atomics for lcore sync > test/bpf: use compiler atomics for calculation > test/func_reentrancy: use compiler atomics for data sync > app/eventdev: use compiler atomics for shared data sync > app/crypto: use compiler atomic builtins for display sync > app/compress: use compiler atomic builtins for display sync > app/testpmd: remove atomic operations for port status > app/bbdev: use compiler atomics for shared data sync > app: remove unnecessary include of atomic header file There were cleanups of unneeded rte_atomic.h inclusion along the series: I moved all of them to the last patch so that patches focus on what their commitlog describes. Series applied, thanks. -- David Marchand