From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27AB3A0542; Wed, 26 Oct 2022 10:41:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C497F40A7F; Wed, 26 Oct 2022 10:41:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AF950400D6 for ; Wed, 26 Oct 2022 10:41:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666773709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fus+SwER4SQeggzM7oxDytTxhslZYbq26bJ0F7iAfIg=; b=E51W+r1yL6h8GymIPhbsufwZLEJgYixcxo2nPfkAtfPdB8Olhkju3u2VG324laa15SxGwE wr5lpGSlvVT9rnsFTxANc+vBHv5M44gdecAMUjDpapFg/tJHWqvsKnAh+vzZwzkd1LWV20 xRsYcSAHtGGKLaed8ymqGhLoZu0mxSg= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-513-kw5d2mqmNTOzhmKwdeqlTw-1; Wed, 26 Oct 2022 04:41:48 -0400 X-MC-Unique: kw5d2mqmNTOzhmKwdeqlTw-1 Received: by mail-pg1-f197.google.com with SMTP id k16-20020a635a50000000b0042986056df6so7584138pgm.2 for ; Wed, 26 Oct 2022 01:41:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fus+SwER4SQeggzM7oxDytTxhslZYbq26bJ0F7iAfIg=; b=IOX0bA7Jpg5O0RDoxomUrqfcIE79/QhAElgPXh0s4in7g2aLnUDweRGspx+b6rLIvj lXFx0tzGxQrfmB/coASMmk7tGpIWYoUEpD768AP05ZoED9504+nkjahIjShBf6a7cEAT YoACQ921b6SrrErUxHumElskbO2K4O6iBcwuTMAtIxchM6YUNvRm7os7rV+QjFTqWX4j K3xq6x4ZaDSq3SrXyMQn1rq/l8PLW6XVqWAGFucDrnBBCgrDLWA8zcjjMRho0pd0LDyg iqQOECBmJ/p9t4PsKGfTWr3STPImi4PxRsZu7CJ6/fu+w0+VWaOhV0xKmQaGvN8g5qUa OYQw== X-Gm-Message-State: ACrzQf327ObB7NuscRMpHkuyxBy4Df7L5rIsvEyuE7SdwQrtCN4gyWl9 U+NSf6jNX2TAySXaKZvSFIRm5Q2BydfaDj9CQfxpA7Cd/IQqHU/QuuggCUKQVPr6MZSFrEAWG+d xOKrmwgdUlhJIAM+COao= X-Received: by 2002:a17:903:2307:b0:181:e618:b4c5 with SMTP id d7-20020a170903230700b00181e618b4c5mr41257649plh.172.1666773706963; Wed, 26 Oct 2022 01:41:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7O0NaXNuEfGOTHxSboBAGqqDZJop5nOE517bNXrX6HcNTwVxm173/UvG3iDqhD85F3+hNC0scMn/g5Wtm7YBg= X-Received: by 2002:a17:903:2307:b0:181:e618:b4c5 with SMTP id d7-20020a170903230700b00181e618b4c5mr41257632plh.172.1666773706728; Wed, 26 Oct 2022 01:41:46 -0700 (PDT) MIME-Version: 1.0 References: <20221025214410.715864-1-thomas@monjalon.net> <20221025214410.715864-9-thomas@monjalon.net> In-Reply-To: <20221025214410.715864-9-thomas@monjalon.net> From: David Marchand Date: Wed, 26 Oct 2022 10:41:35 +0200 Message-ID: Subject: Re: [PATCH 8/8] net: mark all big endian types To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, Olivier Matz X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 25, 2022 at 11:46 PM Thomas Monjalon wrote: > diff --git a/lib/net/rte_higig.h b/lib/net/rte_higig.h > index b55fb1a7db..bba3898a88 100644 > --- a/lib/net/rte_higig.h > +++ b/lib/net/rte_higig.h > @@ -112,9 +112,9 @@ struct rte_higig2_ppt_type0 { > */ > __extension__ > struct rte_higig2_ppt_type1 { > - uint16_t classification; > - uint16_t resv; > - uint16_t vid; > + rte_be16_t classification; > + rte_be16_t resv; > + rte_be16_t vid; Compiling with sparse (from OVS dpdk-latest), there are, at least, some annotations missing in the public headers for higig2. lib/ethdev/rte_flow.h:644: .classification = 0xffff, lib/ethdev/rte_flow.h:645: .vid = 0xfff, And the 0xfff mask for a 16 bits field (vid) is suspicious, isn't it? > #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN > uint16_t opcode:3; > uint16_t resv1:2; -- David Marchand