From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F964A00C2; Thu, 6 Oct 2022 08:52:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F7A24280E; Thu, 6 Oct 2022 08:52:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5FD62427F5 for ; Thu, 6 Oct 2022 08:52:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665039136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U12aj0D7Y7g9Q7GHT+Q/GsVn9BFOMqZFS9LB+WpV+4c=; b=e2xlD7dw9kB2ngIZ8qxHmRLJI0xhFB7Ish0LgVLsdWs5qoFzYgFkdiIHoNrhac0hmuH2HP 1LoQcRA6REMvSSVYeTDeInttRAh4bXkUE7NABbpLqusGUa1QcfLa7M3h8rL5Zwgxhd+fxN qNno736gV/MX7wjHG/0fDG8MaUIO6l0= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-605-N2t1_ct0NGys3hNvMHWBLA-1; Thu, 06 Oct 2022 02:52:15 -0400 X-MC-Unique: N2t1_ct0NGys3hNvMHWBLA-1 Received: by mail-pl1-f200.google.com with SMTP id i5-20020a170902c94500b0017c602e7f76so689361pla.22 for ; Wed, 05 Oct 2022 23:52:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=U12aj0D7Y7g9Q7GHT+Q/GsVn9BFOMqZFS9LB+WpV+4c=; b=18w7tEKQkVK1CjUBK5A0dxwcHTlcpZBMMfm4r2nc42QJKHAVRZAlSL3OdsMdpBZgQ9 E2wVXf/r/9RA+S+ovkwGbPBrOGChlMcD0zGAUg3B2KtROqMOteEX8d0n77LVFI2nC0O9 hFztWzQ25mDdtv40f9esnCJDFm97pk+OwjzhpgWgfK5+6gcCnVsp2Z1LzbKBCo9FRxzr I53tklOlUeMnRHoweYQwnYgDaHvDfvN7sg/jHVsNznriPV/OUnn5TVn1qUk/vCA9exs7 0/CnrXOrgyaoqM9TOz4a4/brfV5uYgAiZqotIKqge0Ms0MODIkMKEK2DuJ0J2+kFsB4i 2TKQ== X-Gm-Message-State: ACrzQf2ZSwJdIKLaRMilfOF0EqRcUTWfmAU+7keC7sqANI9AJ+s1g1lt lzaZVkUAed2chzNe69T1inRCix0dj2JugdIjcqJwHEz+z0nrI2jVu6I1S6XCU/RWzCSr+Y5UQX3 2AVn8DDMBndq32jcbaZE= X-Received: by 2002:a17:903:2302:b0:178:286c:86a8 with SMTP id d2-20020a170903230200b00178286c86a8mr2959392plh.172.1665039134650; Wed, 05 Oct 2022 23:52:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5MH2PAet8aEovQr1drH4phEdz2pzyt+EBHK4CDRU6r+wNE4FoLtnioS5Jc8AW96d7DdKGJPO7qa3pP6jaImTk= X-Received: by 2002:a17:903:2302:b0:178:286c:86a8 with SMTP id d2-20020a170903230200b00178286c86a8mr2959378plh.172.1665039134386; Wed, 05 Oct 2022 23:52:14 -0700 (PDT) MIME-Version: 1.0 References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <1656348966-10194-1-git-send-email-roretzla@linux.microsoft.com> <20221005161126.GB7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20221005163439.GC7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20221005163439.GC7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Thu, 6 Oct 2022 08:52:02 +0200 Message-ID: Subject: Re: [PATCH v4 0/6] add thread lifetime and attributes API To: Tyler Retzlaff Cc: thomas@monjalon.net, dmitry.kozliuk@gmail.com, dev@dpdk.org, anatoly.burakov@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 5, 2022 at 6:34 PM Tyler Retzlaff wrote: > > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > hi David, > > > > > > > > > > Newly added code can go to eal_common_thread.c rather than introduce a > > > new common/rte_thread.c file (or is there a rationale for this?). > > > > i will make this change in the next revision. if anyone does object i > > hope they will do so quickly. > > looking at this more closely i'm going to back away from making the > adjustment here. if Thomas and/or Dmitry could comment it would be > appreciated. > > it appears that functions placed in eal_common_xxx files are consumed > internally by the eal where rte_xxx files are functions that are exposed > through public api. > > since these additions are public api it seems they should remain in > rte_thread.c > > i won't change this in the next revision, but please do correct me if > i'm still not on track. This seems a fair argument. I'll reply on the v5 series: compilation is still broken at patch 4. -- David Marchand