Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file

[David Marchand <david.marchand@redhat.com>]

On Tue, Apr 6, 2021 at 6:33 PM David Marchand <david.marchand@redhat.com> wrote:
> diff --git a/buildtools/map_to_win.py b/buildtools/map_to_win.py
> index 2a6cb88605..34434d96fa 100644
> --- a/buildtools/map_to_win.py
> +++ b/buildtools/map_to_win.py
> @@ -7,7 +7,7 @@
>
>
>  def is_function_line(ln):
> -    return ln.startswith('\t') and ln.endswith(';\n') and ":" not in ln
> +    return ln.startswith('\t') and ln.endswith(';\n') and ":" not in ln and "# WINDOWS_NO_EXPORT" not in ln
>
>  # MinGW keeps the original .map file but replaces per_lcore* to __emutls_v.per_lcore*
>  def create_mingw_map_file(input_map, output_map):
> @@ -24,12 +24,6 @@ def main(args):
>          create_mingw_map_file(args[1], args[2])
>          return 0
>
> -# special case, allow override if an def file already exists alongside map file
> -    override_file = join(dirname(args[1]), basename(args[2]))
> -    if exists(override_file):
> -        with open(override_file) as f_in:
> -            functions = f_in.readlines()
> -

Forgot to clean associated python imports.
Will be fixed in a v2 if no objection is raised on the principle of the patch.


>  # generate def file from map file.
>  # This works taking indented lines only which end with a ";" and which don't
>  # have a colon in them, i.e. the lines defining functions only.


-- 
David Marchand