From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2618FA09E0; Sat, 14 Nov 2020 12:13:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BAE8C88E; Sat, 14 Nov 2020 12:13:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 191BBC882 for ; Sat, 14 Nov 2020 12:13:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605352393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kjlFhVdeDOxt/lgQqh9W4VAO5STEM9JAO+qhLmszc3U=; b=SbjypvH6IIvLRd7KrbepIrP8ibL2jrRVaA2F8f1y/lUZARgVeOmZGYAPg2MPvNik3ZxAPZ jkwYWhBfHvSIILfAW9gHkG3mW+xviwazcyfLYKGsombx6k32omr/24G+4nPeumq3pO5oid y48VHzGTZUiPfjU+7xdKFQlTVQEBobk= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217--bOceDKeP_qlruJ-lZAZBg-1; Sat, 14 Nov 2020 06:13:11 -0500 X-MC-Unique: -bOceDKeP_qlruJ-lZAZBg-1 Received: by mail-vk1-f198.google.com with SMTP id t72so3368149vke.4 for ; Sat, 14 Nov 2020 03:13:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kjlFhVdeDOxt/lgQqh9W4VAO5STEM9JAO+qhLmszc3U=; b=Q1vSTmzVhsdq78Ox1At/YBHqtKY2iDDjasee8/APR9uceFmbyleiMhwh91IoMWDZAj DMvw6bMc4N/8mw90wDn0CStp9LDz9uNx7rZCvlwFVMYc5U7autHb3nWTfiQZ4AYDcNGg Y/pGYa1ANBQe/ZRyat33twsn+B0d/poW2+ByvOf/aXCh3vRSKsibzLUjsCvB1KqmzSQp g0rnFLBK0E+6RBNWNJSJyWpI3YR8NKPhOX0gaTcVQsDuhyURLjbLRB8GnULsxHwXLhNZ WRDqci8oAI/oshxcF03a5Ka6E9OtLR/niPgNB5SR+HDXQJs6B8fxKmpk+VSABW/kLvZR WZDw== X-Gm-Message-State: AOAM531TeSrIIzKs7BWzTDwcK9rZXRoDfLJD4g3QsBjiQdfr1WtyQQcx 5KeaMXHRU63U+hiOkYqu+awIRKicX0G3hhk1Hs96HaD7XBGrESzMoVCofww3vFntDpwZmyAGWcH y95+2x3EnDbVbDifQQXs= X-Received: by 2002:ab0:39ca:: with SMTP id g10mr3113766uaw.126.1605352390467; Sat, 14 Nov 2020 03:13:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1ihvJPaR6jEJKikKehuJJBj0iYk5ruvSexT5vX4XLFWVc66yXlqRw9Ir86ibwaPJ7bglp2XDIf+LtBkroKYE= X-Received: by 2002:ab0:39ca:: with SMTP id g10mr3113755uaw.126.1605352390269; Sat, 14 Nov 2020 03:13:10 -0800 (PST) MIME-Version: 1.0 References: <20201111081507.19913-1-ibtisam.tariq@emumba.com> <20201111081507.19913-5-ibtisam.tariq@emumba.com> In-Reply-To: <20201111081507.19913-5-ibtisam.tariq@emumba.com> From: David Marchand Date: Sat, 14 Nov 2020 12:12:59 +0100 Message-ID: To: Ibtisam Tariq Cc: Maxime Coquelin , "Xia, Chenbo" , Cristian Dumitrescu , "Singh, Jasvinder" , "Mcnamara, John" , "Pattan, Reshma" , "Ananyev, Konstantin" , "Kovacevic, Marko" , dev , Stephen Hemminger Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 5/7] examples/qos_sched: enhance getopt_long usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 11, 2020 at 9:17 AM Ibtisam Tariq wrote: > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readability and consistency in > all examples. > > Bugzilla ID: 238 > Cc: stephen@networkplumber.org > > Reported-by: David Marchand > Signed-off-by: Ibtisam Tariq This patch breaks compilation with clang: https://travis-ci.com/github/ovsrobot/dpdk/jobs/433053506#L1019 You can remove this str_is helper. -- David Marchand