From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D266542CB3; Wed, 14 Jun 2023 17:08:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7E4340E0F; Wed, 14 Jun 2023 17:08:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3F8FE40DDB for ; Wed, 14 Jun 2023 17:08:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686755297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UYyMbjZ2AxYdC0OTvIAtdX0Y5iywH5jaoyzTfEbpZso=; b=QVIubnO/inuEfgnMTfBIP7JVgMzTPckAVJbTHGimqx1fHC72gKfT/OUTMVeZ99uLIjXwvs Oa0XiI61jzD7Siirdb6JYl4Fj4/wIbvDgQ7yn8MH/j32+odVHlZlb7MjmWGkODHTSTQjI/ jrs4aGGt7bk3285RRL4dItVCVAXniBo= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-L90JnpBFNi2Ri98w-DppvA-1; Wed, 14 Jun 2023 11:08:16 -0400 X-MC-Unique: L90JnpBFNi2Ri98w-DppvA-1 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-53f6e194e7bso5037884a12.1 for ; Wed, 14 Jun 2023 08:08:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686755295; x=1689347295; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UYyMbjZ2AxYdC0OTvIAtdX0Y5iywH5jaoyzTfEbpZso=; b=cgKNH8IrtmZWY7p0PK0O4/CdxSBAZahlaCcomy/XHs2AmH1KhWW0S5cGC44iZqYzA4 XXr/ZKuoCNZvDfYz/YZu/etQ+GqKOEhM32IQZJl9cZXeY60hTnmdFPFs4FsaN0p4DdTf VYYqdLm9UN3dETAxz2AM4EwxLtdLO+MJcFtuRaE9L0ZVbcCE9QCvL3Peg03GexbAAFma HBQYOOoApXYBvd4FrVgy5bqlXdO++vQJkAQSzZITB4xPnurOk87YGFncjGjp540Nzs0M 68+Gsl+pXJnjJZjmDF+vs0ZVChI3dKCYYC0wlqj+t3Ha71mKAFnUB2QHX69BmiychOdi 7o+w== X-Gm-Message-State: AC+VfDzhPUziB8wpwmTFIaWwDeczvpkTxh2BAfuSvHZ+fFa//YT1f2OI /+wUskZndFgmrrxAouCtOBF0c7YG490Hk2cMtoRaZtNFVr6dCG7to68D/cAXFlbc9lcKKTp2aVn gf+i081dJj6C+6xSN+OE= X-Received: by 2002:a05:6a20:6a0c:b0:117:428d:f983 with SMTP id p12-20020a056a206a0c00b00117428df983mr2624116pzk.1.1686755294992; Wed, 14 Jun 2023 08:08:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4dquqUmHQ5i5OtHn+0s3rZsAJlgwzbHBIqyl7/i64Ifx6ae2uhzwl1B9PIQcQPn6bTPi41FVyGGqLR/zx5JSw= X-Received: by 2002:a05:6a20:6a0c:b0:117:428d:f983 with SMTP id p12-20020a056a206a0c00b00117428df983mr2624096pzk.1.1686755294743; Wed, 14 Jun 2023 08:08:14 -0700 (PDT) MIME-Version: 1.0 References: <20230614142651.1456116-1-thomas@monjalon.net> In-Reply-To: From: David Marchand Date: Wed, 14 Jun 2023 17:08:03 +0200 Message-ID: Subject: Re: [PATCH 0/5] cleanup in library header files To: Jerin Jacob Cc: Thomas Monjalon , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 14, 2023 at 4:42=E2=80=AFPM Jerin Jacob = wrote: > > On Wed, Jun 14, 2023 at 8:01=E2=80=AFPM Thomas Monjalon wrote: > > > > While pulling some trees for DPDK 23.07-rc1, > > I've seen that some wrong coding style for comments > > were copied over and over. > > > > In order to avoid copying wrong comment style, > > the three first patches are fixing a lot of comments. > > As it is not critical, they are not marked for backport. > > > > While looking the header files, I've fixed some misuses of "extern". > > Thanks for the cleanup. IMO, it is better to update > ./devtools/checkpatches.sh or so to flag these issue before getting to > repo for new changes, Those are not easy to spot. +1 to add a check if that won't raise false positives. --=20 David Marchand