From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 471D6A0096
	for <public@inbox.dpdk.org>; Mon,  3 Jun 2019 18:14:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 16D5B1B94D;
	Mon,  3 Jun 2019 18:14:12 +0200 (CEST)
Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com
 [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id B2BCD4F91
 for <dev@dpdk.org>; Mon,  3 Jun 2019 18:14:10 +0200 (CEST)
Received: by mail-vs1-f65.google.com with SMTP id d128so11567137vsc.10
 for <dev@dpdk.org>; Mon, 03 Jun 2019 09:14:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=NGc/BItWHs8U5pwhBRLbcL7OZAaMS7bflFsdzjG8m80=;
 b=kdiDaXbIuWtl5iBBIuPyRO3dOKhJSFOzbW5iClUQiim8ukN+1p/XLuI4AsdDHFwfiS
 xvIOYaikY2LH1Dzo5AxzrfKE9aJhOicY5zRD6ALjzEOeNaLx8JWgGueEuqfL5wL5/hiC
 OkFL/SJASmEtRCsJguzGEeQYt/xrmwHxY706AhBVjZWUFpaA3y04vg6wtfb6al1r5KwP
 lqtH4pxeV70i05yqeezerEdndWPvsDoWNWUVDRYKzhaCHW/CrwvbwZpn3fIz7QgQRqWx
 SV+Ew4fEbWTzPkGIeXMEB3k3jb5iqt1f0lk9YvbpQKJpk1beis4s7M1g3C60gvKYUUFs
 B2ig==
X-Gm-Message-State: APjAAAVE4XNTF5ZwHU+k368oD8suX75mWVkMRWI5jYOFgR60MIRJj/l8
 i8UvZ47dFkP3ygzsShDOU3B1r8tCB+/HlEubMyayQA==
X-Google-Smtp-Source: APXvYqx3h19uxnf3NHpPN1hthOLlfUDW2KWLiieZcvZMVktM2Tn4nz821hiHxHJSoV0Agr3prH/UOx2ro66fnTNQIyg=
X-Received: by 2002:a67:1885:: with SMTP id 127mr7083332vsy.39.1559578450134; 
 Mon, 03 Jun 2019 09:14:10 -0700 (PDT)
MIME-Version: 1.0
References: <CGME20190530132538eucas1p28fcfddad5b73d3a0baf7095f25a6c1fd@eucas1p2.samsung.com>
 <20190530132526.3496-1-i.maximets@samsung.com>
 <CAJFAV8x3Y_4UcdeEVdMHnxW2BPbgkmw=TO0pMm35t00Npwq+GA@mail.gmail.com>
 <4dd83792-1418-dc82-9e98-a993438faab9@samsung.com>
In-Reply-To: <4dd83792-1418-dc82-9e98-a993438faab9@samsung.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 3 Jun 2019 18:13:58 +0200
Message-ID: <CAJFAV8xhNf+w1KMGdtVXfHT8CJFOigbu3KDwDPqRj=OP4beeAA@mail.gmail.com>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, 
 Anatoly Burakov <anatoly.burakov@intel.com>, Jan Blunck <jblunck@infradead.org>,
 Qi Zhang <qi.z.zhang@intel.com>, Kevin Traynor <ktraynor@redhat.com>, 
 dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix positive error codes
	from probe/remove
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jun 3, 2019 at 5:37 PM Ilya Maximets <i.maximets@samsung.com> wrote:

> On 03.06.2019 11:50, David Marchand wrote:
> >
> >
> > On Thu, May 30, 2019 at 3:26 PM Ilya Maximets <i.maximets@samsung.com
> <mailto:i.maximets@samsung.com>> wrote:
> >
> >     According to API, 'rte_dev_probe()' and 'rte_dev_remove()' and their
> >     'hotplug' equivalents must return 0 or negative error code. Bus code
> >
> >
> > About this first part, existing callers in dpdk are not consistent with
> the api which might explain why this was not seen earlier.
> > How about fixing the existing callers?
>
> Do you mean replacing all the 'rte_dev_probe() != 0' with 'rte_dev_probe()
> < 0'
> around the codebase?
>

Yes.
It is not necessary to this patch so I can handle it if you don't have time.
But dpdk should show a good example by respecting its own apis description.


-- 
David Marchand