From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EBD9A04B8; Tue, 5 May 2020 18:16:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D57CB1D653; Tue, 5 May 2020 18:16:41 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 4F7DD1D14F for ; Tue, 5 May 2020 18:16:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588695399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MvdaTyV/EQ6xTD0g9I2ha2iz+XUIKaMphwK3dB38zak=; b=VK2nnR91eYk2/na5ntwsU/vM+qZ7v+l5XDaqORe+wHHaMilQUcAVlh6+5FtQDIb8HLz2u5 uOq4G9rDQSQYFbJjdoAK/82ha54GuniGYnvY8MLR0ThR0v9y0NtWnpuu8QN0syyH2yJ/NQ 7LhvWeZwa3/53915CIw7N5ivkO0j+3Y= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-0aLE-yDJP0ixag91SRrV7Q-1; Tue, 05 May 2020 12:16:38 -0400 X-MC-Unique: 0aLE-yDJP0ixag91SRrV7Q-1 Received: by mail-vk1-f198.google.com with SMTP id j206so1222397vke.11 for ; Tue, 05 May 2020 09:16:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AnYAVFPLG1oh0BCMbUmMhx/A0mVr9yKkq93JvL0/SYg=; b=a/hqfbtQIamqix9+14mQGdTupoDiLLdKpUwt8PJuUrG1ssAjGcO/0hbaGxEo1iHMBK I/PCZEmj3xtZW4dAYL28P8/qZUfA9lReI+/ZWOqaoVYsWbBOTTV5dRvyeOPFJo+/X07t Q49CqPi+s0gVOmBayq1/EXYm/WGfgWYz2XmcfokM35vZoEqFlhehcjuAefEDOCknc54p JMsFLKCVP9YLLChcmYF7Qp6ITM0iTAk7bHBAY50FRPNpVrrW6NhNlFucMlq8Zn6Yz20N ww/hFYBO4sLEIHqp5ggsa0rFjvuj6mBOfSXKS5jY6LqEmh+kgK2UDcqN4aMSjbnIP4ja vpSg== X-Gm-Message-State: AGi0Puby+xYLrNxVEe10QyQQ31qjjoW6rkZIb6NKVUiNa7gf77zcbgfA rSOs0m2/5psHSLMUYvqVBvqKEF4u91rp2ci0xcmAJeW3q+GqlCn67TZaNZCQhEZlcX86niAfjx4 0Ua+99fEnPffpb3NlYj0= X-Received: by 2002:a1f:8cc3:: with SMTP id o186mr3241285vkd.18.1588695397876; Tue, 05 May 2020 09:16:37 -0700 (PDT) X-Google-Smtp-Source: APiQypKDClToyoS5mJ0A84jxutXv8RYcEk0MK53pDt06IICTKS4KRR7HDaNzhdwpfvGpChzhKomRY/2WWO5iTr61arM= X-Received: by 2002:a1f:8cc3:: with SMTP id o186mr3241239vkd.18.1588695397516; Tue, 05 May 2020 09:16:37 -0700 (PDT) MIME-Version: 1.0 References: <20200426173811.49788-1-jerinj@marvell.com> <3102527.CAdn2TfLgq@thomas> <6277521.uz5P2jW1tq@thomas> In-Reply-To: From: David Marchand Date: Tue, 5 May 2020 18:16:26 +0200 Message-ID: To: Jerin Jacob , Maxime Coquelin Cc: Thomas Monjalon , Jerin Jacob , dpdk-dev , Zhihong Wang , "Ye, Xiaolong" , Harman Kalra , Kevin Traynor , Luca Boccassi , Gaetan Rivet X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: > > > > > > Removing this special case could break x86 applications running with > > > legacy virtio. > > > > > > > > > On the plus side, we have been announcing for some time in virtio: > > > RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio | uio_pci_generic | = vfio-pci"); > > > > What is to conclude? > > # The In-tree virtio driver uses ""* igb_uio | uio_pci_generic | > > vfio-pci"" driver as backend and it does not need RTE_KDRV_NONE? > > OR > > # The in-tree, legacy virtio(const struct virtio_pci_ops legacy_op) > > can work without any kernel driver in the backend. So RTE_KDRV_NONE > > need? > > Ping. What is the conclusion? If it is former then this patch is valid. I am fine with dropping the legacy part, but I wanted to hear from Maxime at least. --=20 David Marchand