From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9248A0C4C; Tue, 5 Oct 2021 15:57:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CFE740685; Tue, 5 Oct 2021 15:57:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 1042C4014F for ; Tue, 5 Oct 2021 15:57:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633442261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hJzvUIAm3pnBQcTYfsz+lDZiSVJus2KEzOdTPae7bi4=; b=HGlLHRzkcJWxt5KKYPfVkcmXpS6SWP6bf9gHjjq+cBi/CgGj+8K1st18mEtHcI1W4TocPs gDeDWiaL7wm3csmpZyNYK1vmlL1FyQ/9+9c8olsEm4LyYZxq5uXgDHmge4XcnrL0RkQg0r Wb3qvc1/MFXJEsNdpymAWun7O/BHiMo= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-mkY2B5mZMxOZVvkHfGcA1Q-1; Tue, 05 Oct 2021 09:57:40 -0400 X-MC-Unique: mkY2B5mZMxOZVvkHfGcA1Q-1 Received: by mail-lf1-f71.google.com with SMTP id n22-20020a0565120ad600b003fcc09af59fso16991127lfu.21 for ; Tue, 05 Oct 2021 06:57:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hJzvUIAm3pnBQcTYfsz+lDZiSVJus2KEzOdTPae7bi4=; b=nvSnaTp3WvG3FMvamFZ7WImsyW/eLVTu/VwtcF3g8Z0fF1fp8c1n0HwA7/4HhZgir0 I1JnrfrwcSxDZ9aMbG1ZDYSHsV3FGj7GQ9iwH/fC0KCvUS1Q1Sqr0opnOdbrveW12Xag BzOi0o6XzIcgjdm6Gqo+btXfFSXQkVSEBJnY6cPcn6oLFMlqD41HRNt01CMaB3cqwA7x Nsahip5AWZkv4AdXsiOvJeSbGk/DEBxaT84gte7iq7wt525MOzZR0M2RHIYzjsw3QrFu AlgZ9rAUNKIoRmyD0Y6hlyaUQON+K1Tf4wKr40ivThdaLdaxhyPTKX7cfe0IGPhA+U2K gS3A== X-Gm-Message-State: AOAM531Z5nzHZzwcU+kI0vxQRLkeq7FIvc0XuHTx6LRuLH5m5NkkVkoJ Tud+TrYSf0g4kN4jRTfYEbJKK1HjuH+33Hj3c/tD1aIn63iko28JNKFH7jvRdHGeWTPOMlObCA2 ikbdnxJO2afMfPATOSTU= X-Received: by 2002:a05:6512:3f16:: with SMTP id y22mr3622291lfa.499.1633442258976; Tue, 05 Oct 2021 06:57:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSEMXuZlHvqgGFoBB40RfMWTnGE5cid7ZvXAjCTHHWRCbfiX8rjgVi+xdcoE8uIb0B78DkiXlr2ijQkPoIpOY= X-Received: by 2002:a05:6512:3f16:: with SMTP id y22mr3622278lfa.499.1633442258790; Tue, 05 Oct 2021 06:57:38 -0700 (PDT) MIME-Version: 1.0 References: <20211005115754.34117-1-aman.deep.singh@intel.com> In-Reply-To: <20211005115754.34117-1-aman.deep.singh@intel.com> From: David Marchand Date: Tue, 5 Oct 2021 15:57:27 +0200 Message-ID: To: Aman Singh , "Yigit, Ferruh" Cc: dev , dpdk stable , Qi Zhang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix build error for GCC 4.8.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 5, 2021 at 2:07 PM Aman Singh wrote: > > Code changes done for build issue as reported in Bug 817 > error: dereferencing type-punned pointer will break strict-aliasing rules. > added union to avoid pointer dereferencing > About the title, Ali reproduced the issue with other versions of gcc. This patch touches base/ code, is Intel ok with this? Else, we could consider disabling strict aliasing for the base driver, like $ git grep alias '**/base/meson.build' drivers/net/fm10k/base/meson.build: '-Wno-strict-aliasing', '-Wno-format-extra-args', drivers/net/i40e/base/meson.build: '-Wno-strict-aliasing', '-Wno-unused-but-set-variable', drivers/net/qede/base/meson.build: '-Wno-strict-aliasing', Bugzilla ID: 817 > Fixes: 39925373a333 ("net/ice/base: add parser execution main loop") No Cc: stable, this is a regression in main. > Signed-off-by: Aman Singh Tested-by: David Marchand -- David Marchand